Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

makes: move common FLAGS to Makefile.common + rearrange makefiles #154

Merged
merged 3 commits into from
Sep 7, 2023

Conversation

nalajcie
Copy link
Member

@nalajcie nalajcie commented Sep 7, 2023

Description

  • makes: move common FLAGS to Makefile.common
    Also:
    • introduce CPPFLAGS (C preprocessor flags)
    • export only target-related CFLAGS/LDFLAGS for ports
      (exceptions -f*-sections and --gc-sections)
    • remove unused RAM_SIZE define for armv7m
    • fix ports not being linked with --gc-sections
  • makes: rename target-specific makefiles
    Use suffix (.mk) to represent the file type.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Motivation and Context

Reduce technology debt.

JIRA: CI-334

How Has This Been Tested?

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing linter checks and tests passed.
  • My changes generate no new compilation warnings for any of the targets.

Special treatment

  • This PR needs additional PRs to work (list the PRs, preferably in merge-order).
  • I will merge this PR by myself when appropriate.

Use suffix (.mk) to represent the file type.

JIRA: CI-334
Also:
 - introduce CPPFLAGS (C preprocessor flags)
 - export only target-related CFLAGS/LDFLAGS for ports
   (exceptions -f*-sections and --gc-sections)
 - remove unused RAM_SIZE define for armv7m
 - fix ports not being linked with --gc-sections

JIRA: CI-334
agkaminski
agkaminski previously approved these changes Sep 7, 2023
Copy link
Member

@agkaminski agkaminski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nalajcie nalajcie merged commit 2aafb0a into master Sep 7, 2023
8 of 21 checks passed
@nalajcie nalajcie deleted the nalajcie/build branch September 7, 2023 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants