Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

toolchain: fix multilib flags for SPARC #205

Merged
merged 1 commit into from
Sep 12, 2024
Merged

Conversation

lukileczo
Copy link
Member

@lukileczo lukileczo commented Sep 12, 2024

JIRA: RTOS-918

Description

Add PIC flags to libstdcpp only when the mulitlib requires it.
Change -fPIE multilib flag to -fPIC

Motivation and Context

libstdcpp wasn't compiled with appriopriate flags on SPARC MMU platforms.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (refactoring, style fixes, git/CI config, submodule management, no code logic changes)

How Has This Been Tested?

  • Already covered by automatic testing.
  • New test added: (add PR link here).
  • Tested by hand on: sparcv8leon3-generic-qemu

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing linter checks and tests passed.
  • My changes generate no new compilation warnings for any of the targets.

Special treatment

  • This PR needs additional PRs to work (list the PRs, preferably in merge-order).
  • I will merge this PR by myself when appropriate.

@lukileczo
Copy link
Member Author

@badochov could you please check if sparc NOMMU still works correctly?

Copy link

github-actions bot commented Sep 12, 2024

Unit Test Results

7 700 tests   6 985 ✅  37m 41s ⏱️
  436 suites    715 💤
    1 files        0 ❌

Results for commit b18ad0f.

♻️ This comment has been updated with latest results.

@lukileczo lukileczo changed the title toolchain/libstdcpp: fix multilib flags for SPARC toolchain: fix multilib flags for SPARC Sep 12, 2024
Copy link
Contributor

@badochov badochov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lukileczo lukileczo merged commit 52927a8 into master Sep 12, 2024
30 checks passed
@lukileczo lukileczo deleted the lukileczo/fix-sparc-cpp branch September 12, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants