Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hal/imxrt106x: fix enet PLL init #601

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

hal/imxrt106x: fix enet PLL init #601

wants to merge 1 commit into from

Conversation

julianuziemblo
Copy link
Contributor

@julianuziemblo julianuziemblo commented Sep 26, 2024 •
edited
Loading

Description

Fix _imxrt_ccmInitEnetPll to correctly initialize enet PLL.

Motivation and Context

Enet PLL clk0 is enabled using bit 13 of CCM_ANALOG_PLL_ENET register, but the shift for enclk0 was 12, which does not match the iMX RT106x RM.
Additionally, bypass was needed during the frequency change.

Related: phoenix-rtos/plo#355

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (refactoring, style fixes, git/CI config, submodule management, no code logic changes)

How Has This Been Tested?

  • Already covered by automatic testing.
  • New test added: (add PR link here).
  • Tested by hand on: armv7m7-imxrt106x-evk.

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing linter checks and tests passed.
  • My changes generate no new compilation warnings for any of the targets.

Special treatment

  • This PR needs additional PRs to work (list the PRs, preferably in merge-order).
  • I will merge this PR by myself when appropriate.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 26, 2024 •
edited
Loading

Unit Test Results

7 725 tests  +2   7 010 ✅ +2   37m 3s ⏱️ - 1m 33s
  445 suites +2     715 💤 ±0 
    1 files   ±0       0 ❌ ±0 

Results for commit 8aa673b. ± Comparison against base commit a1a6787.

♻️ This comment has been updated with latest results.

@julianuziemblo julianuziemblo mentioned this pull request Sep 26, 2024
Merged
14 tasks
@nalajcie
Copy link
Member

imxrt19xx?

@julianuziemblo julianuziemblo changed the title hal/imxrt19xx: fix enet PLL clk0 enable hal/imxrt106xx: fix enet PLL clk0 enable Sep 27, 2024
@julianuziemblo julianuziemblo changed the title hal/imxrt106xx: fix enet PLL clk0 enable hal/imxrt106x: fix enet PLL clk0 enable Sep 27, 2024
@julianuziemblo julianuziemblo mentioned this pull request Sep 30, 2024
Open
14 tasks
agkaminski
agkaminski previously approved these changes Oct 2, 2024
View reviewed changes
nalajcie
nalajcie requested changes Oct 2, 2024
View reviewed changes
Copy link
Member

@nalajcie nalajcie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please copy the full solution from plo (setting bypass while changing the PLL freqency)

@julianuziemblo julianuziemblo force-pushed the julianuziemblo/enet-imxrt106x-evk branch from ce7e2d3 to b0501bf Compare October 3, 2024 07:37
@julianuziemblo julianuziemblo changed the title hal/imxrt106x: fix enet PLL clk0 enable hal/imxrt106x: fix enet PLL init Oct 3, 2024
@julianuziemblo
hal/imxrt106x: fix enet PLL init
8aa673b 
- correct clk0 enable bit
- add bypass during clock frequency change

JIRA: RTOS-507
@julianuziemblo julianuziemblo force-pushed the julianuziemblo/enet-imxrt106x-evk branch from b0501bf to 8aa673b Compare October 3, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agkaminski agkaminski agkaminski approved these changes

@Darchiv Darchiv Awaiting requested review from Darchiv

@nalajcie nalajcie Awaiting requested review from nalajcie

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@julianuziemblo @nalajcie @agkaminski