Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adamdebek/fs mark #62

Merged
merged 1 commit into from
Aug 7, 2023
Merged

Adamdebek/fs mark #62

merged 1 commit into from
Aug 7, 2023

Conversation

adamdebek
Copy link
Contributor

Description

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

How Has This Been Tested?

  • Already covered by automatic testing.
  • New test added: (add PR link here).
  • Tested by hand on: (list targets here).

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing linter checks and tests passed.
  • My changes generate no new compilation warnings for any of the targets.

Special treatment

  • This PR needs additional PRs to work (list the PRs, preferably in merge-order).
  • I will merge this PR by myself when appropriate.

@adamdebek adamdebek force-pushed the adamdebek/fs_mark branch 2 times, most recently from beb474c to 7ef7c12 Compare July 25, 2023 12:53
@damianloew damianloew assigned nalajcie and unassigned nalajcie Jul 28, 2023
@damianloew damianloew requested a review from nalajcie July 28, 2023 12:23
@damianloew damianloew assigned agkaminski and unassigned agkaminski Jul 28, 2023
nalajcie
nalajcie requested changes Jul 28, 2023
View reviewed changes
Copy link
Member

@nalajcie nalajcie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pointed out some issues.

Please also remove the other commit which got here by accident

fs_mark/build.sh Outdated Show resolved Hide resolved
fs_mark/build.sh Outdated Show resolved Hide resolved
fs_mark/patch/fs_mark.patch Outdated Show resolved Hide resolved
@adamdebek adamdebek force-pushed the adamdebek/fs_mark branch 3 times, most recently from 034181e to ed18cb0 Compare July 31, 2023 10:46
nalajcie
nalajcie reviewed Aug 1, 2023
View reviewed changes
Copy link
Member

@nalajcie nalajcie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small nitpicks, otherwise LGTM

fs_mark/build.sh Outdated Show resolved Hide resolved
fs_mark/patch/fs_mark_h.patch Outdated Show resolved Hide resolved
@adamdebek adamdebek force-pushed the adamdebek/fs_mark branch 2 times, most recently from aae1b0e to 3fd8ffa Compare August 1, 2023 10:33
nalajcie
nalajcie previously approved these changes Aug 1, 2023
View reviewed changes
agkaminski
agkaminski previously approved these changes Aug 2, 2023
View reviewed changes
Copy link
Member

@agkaminski agkaminski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adamdebek
add fs_mark port
04348f6 
JIRA: CI-306
@adamdebek adamdebek dismissed stale reviews from agkaminski and nalajcie via 04348f6 August 2, 2023 14:59
@adamdebek adamdebek merged commit a4f2248 into master Aug 7, 2023
25 checks passed
@adamdebek adamdebek deleted the adamdebek/fs_mark branch August 7, 2023 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damianloew damianloew damianloew approved these changes

@nalajcie nalajcie nalajcie left review comments

@agkaminski agkaminski agkaminski left review comments

@ziemleszcz ziemleszcz Awaiting requested review from ziemleszcz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@adamdebek @nalajcie @agkaminski @damianloew