Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lighttpd: Fix mod_wstunnel not being built in static build #70

Closed
wants to merge 1 commit into from
Closed

lighttpd: Fix mod_wstunnel not being built in static build #70

wants to merge 1 commit into from

Conversation

Darchiv
Copy link
Member

@Darchiv Darchiv commented Dec 15, 2023

JIRA: DTR-460

Description

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

How Has This Been Tested?

  • Already covered by automatic testing.
  • New test added: (add PR link here).
  • Tested by hand on: (list targets here).

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing linter checks and tests passed.
  • My changes generate no new compilation warnings for any of the targets.

Special treatment

  • This PR needs additional PRs to work (list the PRs, preferably in merge-order).
  • I will merge this PR by myself when appropriate.

@nalajcie
Copy link
Member

Seems to be working. I'm a little bit afraid about additional dependencies needed for other platforms (Darwin, windows) needed for autogen to work.

@nalajcie
Copy link
Member

alternative approach to consider: #71

@Darchiv Darchiv force-pushed the danielsawka/lighttpd_wstunnel branch from 959eabf to 940ac11 Compare December 18, 2023 15:06
@Darchiv Darchiv closed this Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Darchiv @nalajcie