busybox: add IPv6 support #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
mateuszkobak
force-pushed
the
mateuszkobak/ipv6
branch
from
a14f4d7
to
b0d6a03
Compare
mateuszkobak
force-pushed
the
mateuszkobak/ipv6
branch
from
b0d6a03
to
0aede7f
Compare
nalajcie
reviewed
Apr 18, 2024
mateuszkobak
force-pushed
the
mateuszkobak/ipv6
branch
from
0aede7f
to
2e6b2c6
Compare
nalajcie
reviewed
Apr 18, 2024
mateuszkobak
force-pushed
the
mateuszkobak/ipv6
branch
from
2e6b2c6
to
bba10b4
Compare
nalajcie
approved these changes
Apr 19, 2024
|
Please rebase |
Add nonblocking option for socket JIRA: COG-42
Change the way ifconfig obtains the IPv6 addresses JIRA: COG-42
mateuszkobak
force-pushed
the
mateuszkobak/ipv6
branch
from
bba10b4
to
ffa3cee
Compare
Unit Test Results7 723 tests +23 7 008 ✅ +23 37m 51s ⏱️ -40s Results for commit ffa3cee. ± Comparison against base commit df40217. This pull request removes 1 and adds 24 tests. Note that renamed tests count towards both. |
|
Rebased |
badochov
reviewed
Oct 4, 2024
| + inet_ntop(AF_INET6, &addr->sin6_addr, addr6, 50); | ||
| + | ||
| + /* Get the prefix length */ | ||
| + unsigned char *c = ((struct sockaddr_in6 *)ifap->ifa_netmask)->sin6_addr.s6_addr; |
There was a problem hiding this comment.
This breaks: -Wdeclaration-after-statement declared in Makefile.flags of busybox. For some reason on GCC 9.5 warn is not issued but on gcc 14.2 it is.
There was a problem hiding this comment.
Update its also triggered on 9.50 my bad
badochov
reviewed
Oct 4, 2024
| sockfd6 = xsocket(AF_INET6, SOCK_DGRAM, 0); | ||
| - xioctl(sockfd6, SIOCGIFINDEX, &ifr); | ||
| - ifr6.ifr6_ifindex = ifr.ifr_ifindex; | ||
| - ifr6.ifr6_prefixlen = prefix_len; |
There was a problem hiding this comment.
This break -Wunused-but-set-variable on prefix_len which is part of -Wall
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
route.ccompile by includingnet/ip6_route.hMotivation and Context
Types of changes
How Has This Been Tested?
Checklist:
Special treatment
Add support for IPv6 phoenix-rtos-lwip#93
Add support for IPv6 libphoenix#355