Add coreMQTT library #80

mateuszkobak · 2024-07-03T14:07:03Z

Description

Porting a lightweight MQTT client library coreMQTT

JIRA-NIL588

Motivation and Context

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Chore (refactoring, style fixes, git/CI config, submodule management, no code logic changes)

How Has This Been Tested?

Already covered by automatic testing.
New test added: (add PR link here).
Tested by hand on: armv7m7-imxrt117x.

Checklist:

My change requires a change to the documentation.
I have updated the documentation accordingly.
I have added tests to cover my changes.
All new and existing linter checks and tests passed.
My changes generate no new compilation warnings for any of the targets.

Special treatment

This PR needs additional PRs to work (list the PRs, preferably in merge-order).
build: Add common utility functions, tidy up build process #78
I will merge this PR by myself when appropriate.

github-actions · 2024-07-03T14:23:28Z

Unit Test Results

6 780 tests - 680 6 154 ✅ - 591 32m 26s ⏱️ - 4m 9s
380 suites - 40 626 💤 - 89
1 files ± 0 0 ❌ ± 0

Results for commit 1553a5e. ± Comparison against base commit b659aa2.

This pull request removes 890 and adds 210 tests. Note that renamed tests count towards both.

flash ‑ armv7a9-zynq7000-zedboard:flash
phoenix-rtos-tests/cpp/hello-cpp ‑ armv7a9-zynq7000-zedboard:phoenix-rtos-tests/cpp/hello-cpp
phoenix-rtos-tests/initfini/main ‑ armv7a9-zynq7000-zedboard:phoenix-rtos-tests/initfini/main
phoenix-rtos-tests/ioctl/unit ‑ armv7a9-zynq7000-zedboard:phoenix-rtos-tests/ioctl/unit.ioctl.data_in
phoenix-rtos-tests/ioctl/unit ‑ armv7a9-zynq7000-zedboard:phoenix-rtos-tests/ioctl/unit.ioctl.data_in_big
phoenix-rtos-tests/ioctl/unit ‑ armv7a9-zynq7000-zedboard:phoenix-rtos-tests/ioctl/unit.ioctl.data_inout
phoenix-rtos-tests/ioctl/unit ‑ armv7a9-zynq7000-zedboard:phoenix-rtos-tests/ioctl/unit.ioctl.data_inout_big
phoenix-rtos-tests/ioctl/unit ‑ armv7a9-zynq7000-zedboard:phoenix-rtos-tests/ioctl/unit.ioctl.data_out
phoenix-rtos-tests/ioctl/unit ‑ armv7a9-zynq7000-zedboard:phoenix-rtos-tests/ioctl/unit.ioctl.data_out_big
phoenix-rtos-tests/ioctl/unit ‑ armv7a9-zynq7000-zedboard:phoenix-rtos-tests/ioctl/unit.ioctl.in_val
…

phoenix-rtos-tests/libc/misc ‑ armv7a7-imx6ull-evk:phoenix-rtos-tests/libc/misc.unistd_file_safe.file_safe_readwrite
phoenix-rtos-tests/libc/misc ‑ armv7a7-imx6ull-evk:phoenix-rtos-tests/libc/misc.unistd_file_safe.file_safe_readwrite_badfd
phoenix-rtos-tests/libc/misc ‑ armv7a7-imx6ull-evk:phoenix-rtos-tests/libc/misc.unistd_file_safe.file_safe_readwrite_zero
phoenix-rtos-tests/libc/misc ‑ armv7a9-zynq7000-qemu:phoenix-rtos-tests/libc/misc.unistd_file_safe.file_safe_readwrite
phoenix-rtos-tests/libc/misc ‑ armv7a9-zynq7000-qemu:phoenix-rtos-tests/libc/misc.unistd_file_safe.file_safe_readwrite_badfd
phoenix-rtos-tests/libc/misc ‑ armv7a9-zynq7000-qemu:phoenix-rtos-tests/libc/misc.unistd_file_safe.file_safe_readwrite_zero
phoenix-rtos-tests/libc/misc ‑ armv7m4-stm32l4x6-nucleo:phoenix-rtos-tests/libc/misc.unistd_file_safe.file_safe_readwrite
phoenix-rtos-tests/libc/misc ‑ armv7m4-stm32l4x6-nucleo:phoenix-rtos-tests/libc/misc.unistd_file_safe.file_safe_readwrite_badfd
phoenix-rtos-tests/libc/misc ‑ armv7m4-stm32l4x6-nucleo:phoenix-rtos-tests/libc/misc.unistd_file_safe.file_safe_readwrite_zero
phoenix-rtos-tests/libc/misc ‑ armv7m7-imxrt106x-evk:phoenix-rtos-tests/libc/misc.unistd_file_safe.file_safe_readwrite
…

♻️ This comment has been updated with latest results.

nalajcie

left some remarks :)

coreMQTT/build.sh

nalajcie · 2024-07-05T09:50:02Z

coreMQTT/build.sh

+
+cp "${PREFIX_COREMQTT}/CMakeLists.txt" "${PREFIX_COREMQTT_BUILD}/CMakeLists.txt"
+
+cmake -S "$PREFIX_COREMQTT_BUILD" -B "$PREFIX_COREMQTT_INSTALL"


what? building inside install dir?

I am not sure how this should be done. Is it better now?

nalajcie · 2024-07-05T09:53:31Z

coreMQTT/build.sh

+
+mkdir -p "$PREFIX_COREMQTT_BUILD" "$PREFIX_COREMQTT_INSTALL"
+if [ ! -f "$PREFIX_COREMQTT/v${COREMQTT_VERSION}.tar.gz" ]; then
+	wget "$PKG_URL" -P "${PREFIX_COREMQTT}" --no-check-certificate;


add mirror location, maybe we can wait for #78 to be merged and use utility functions from there? (@Darchiv)

I am using functions from #78 now, but I haven't created the mirror yet

coreMQTT/CMakeLists.txt

coreMQTT/build.sh

coreMQTT/CMakeLists.txt

coreMQTT/build.sh

JIRA: NIL-595, CI-339

Default version changed from 5.3.5 to 5.3.6. Added port build options: - PORTS_LUA_VERSION - version to download (must be supported by respective patches); - PORTS_LUA_STACK_SIZE - size of Lua's internal stack; - PORTS_LUA_CSTACK_SIZE - size of stack (when using linked lua binary); - PORTS_LUA_COMPAT_5_2 - backward compatibility with Lua 5.2; - PORTS_LUA_DEBUG - enable debug features, e.g. API checks; - PORTS_LUA_INSTALL_TESTS - download and install external Lua test scripts; - PORTS_LUA_RESTRAIN - disable Lua features which may be used to crash the interpreter or perform side-effects in the operating system. JIRA: NIL-595

github-actions · 2024-07-25T11:46:42Z

lua/build.sh

 fi

+mycflags=(
+	${CFLAGS}


⚠️ [shellcheck] _{reported by reviewdog 🐶}
Quote to prevent word splitting/globbing, or split robustly with mapfile or read -a. SC2206

github-actions · 2024-07-25T11:46:43Z

lua/build.sh

 fi

+mycflags=(
+	${CFLAGS}
+	-DLUAI_MAXSTACK=${PORTS_LUA_STACK_SIZE:-2000}


⚠️ [shellcheck] _{reported by reviewdog 🐶}
Quote to prevent word splitting/globbing, or split robustly with mapfile or read -a. SC2206

github-actions · 2024-07-25T11:46:43Z

lua/build.sh

+if [ "${PORTS_LUA_COMPAT_5_2}" = "y" ]; then mycflags+=("-DLUA_COMPAT_5_2"); fi
+if [ "${PORTS_LUA_DEBUG}" = "y" ]; then mycflags+=("-DLUA_USE_APICHECK"); fi
+
+myldflags=(


⚠️ [shellcheck] _{reported by reviewdog 🐶}
Use spaces, not commas, to separate array elements. SC2054

github-actions · 2024-07-25T11:46:43Z

lua/build.sh

+if [ "${PORTS_LUA_DEBUG}" = "y" ]; then mycflags+=("-DLUA_USE_APICHECK"); fi
+
+myldflags=(
+	${LDFLAGS}


⚠️ [shellcheck] _{reported by reviewdog 🐶}
Quote to prevent word splitting/globbing, or split robustly with mapfile or read -a. SC2206

github-actions · 2024-07-25T11:46:43Z

lua/build.sh

+
+myldflags=(
+	${LDFLAGS}
+	-Wl,-z,stack-size=${PORTS_LUA_CSTACK_SIZE:-4096}


⚠️ [shellcheck] _{reported by reviewdog 🐶}
Quote to prevent word splitting/globbing, or split robustly with mapfile or read -a. SC2206

JIRA: NIL-588

github-actions · 2024-09-20T07:53:06Z

build.sh

+	"coreMQTT"
+)
+
+source "${PREFIX_PROJECT}/phoenix-rtos-ports/build.subr"


📝 [shellcheck] _{reported by reviewdog 🐶}
Not following: ./phoenix-rtos-ports/build.subr: openBinaryFile: does not exist (No such file or directory) SC1091

mateuszkobak · 2024-09-20T07:56:14Z

@nalajcie @Darchiv, I revised my code according to your suggestions. Please take a look if it is better now :)

nalajcie reviewed Jul 5, 2024

View reviewed changes

nalajcie requested a review from Darchiv July 5, 2024 10:03

Darchiv reviewed Jul 9, 2024

View reviewed changes

Darchiv added 2 commits July 25, 2024 13:46

build: Add common utility functions, tidy up build process

97f89f0

JIRA: NIL-595, CI-339

mateuszkobak force-pushed the mateuszkobak/NIL-588 branch from 5c4d1d7 to 74b670b Compare July 25, 2024 11:46

github-actions bot reviewed Jul 25, 2024

View reviewed changes

mateuszkobak force-pushed the mateuszkobak/NIL-588 branch from 74b670b to bfc8d6e Compare September 20, 2024 07:46

Add coreMQTT library

1553a5e

JIRA: NIL-588

mateuszkobak force-pushed the mateuszkobak/NIL-588 branch from bfc8d6e to 1553a5e Compare September 20, 2024 07:52

github-actions bot reviewed Sep 20, 2024

View reviewed changes

mateuszkobak marked this pull request as draft September 20, 2024 08:35

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add coreMQTT library #80

Add coreMQTT library #80

mateuszkobak commented Jul 3, 2024 •

edited

Loading

github-actions bot commented Jul 3, 2024 •

edited

Loading

nalajcie left a comment

nalajcie Jul 5, 2024

mateuszkobak Sep 20, 2024

nalajcie Jul 5, 2024

mateuszkobak Sep 20, 2024

github-actions bot Jul 25, 2024

github-actions bot Jul 25, 2024

github-actions bot Jul 25, 2024

github-actions bot Jul 25, 2024

github-actions bot Jul 25, 2024

github-actions bot Sep 20, 2024

mateuszkobak commented Sep 20, 2024


		cp "${PREFIX_COREMQTT}/CMakeLists.txt" "${PREFIX_COREMQTT_BUILD}/CMakeLists.txt"

		cmake -S "$PREFIX_COREMQTT_BUILD" -B "$PREFIX_COREMQTT_INSTALL"

Add coreMQTT library #80

Are you sure you want to change the base?

Add coreMQTT library #80

Conversation

mateuszkobak commented Jul 3, 2024 • edited Loading

Description

Motivation and Context

Types of changes

How Has This Been Tested?

Checklist:

Special treatment

github-actions bot commented Jul 3, 2024 • edited Loading

Unit Test Results

nalajcie left a comment

Choose a reason for hiding this comment

nalajcie Jul 5, 2024

Choose a reason for hiding this comment

mateuszkobak Sep 20, 2024

Choose a reason for hiding this comment

nalajcie Jul 5, 2024

Choose a reason for hiding this comment

mateuszkobak Sep 20, 2024

Choose a reason for hiding this comment

github-actions bot Jul 25, 2024

Choose a reason for hiding this comment

github-actions bot Jul 25, 2024

Choose a reason for hiding this comment

github-actions bot Jul 25, 2024

Choose a reason for hiding this comment

github-actions bot Jul 25, 2024

Choose a reason for hiding this comment

github-actions bot Jul 25, 2024

Choose a reason for hiding this comment

github-actions bot Sep 20, 2024

Choose a reason for hiding this comment

mateuszkobak commented Sep 20, 2024

mateuszkobak commented Jul 3, 2024 •

edited

Loading

github-actions bot commented Jul 3, 2024 •

edited

Loading