Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

!docker-devel.sh: pass arguments in double quotes #1213

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

badochov
Copy link
Contributor

@badochov badochov commented Oct 16, 2024

Entrypoint in phoenixrtos/devel image is bash -l -c which passes additional arguments to bash not to the program rum by bash.

JIRA: RTOS-952

Description

Before: ./docker-devel.sh ./phoenix-rtos-tests/runner.py --target armv7a9-zynq7000-qemu -t phoenix-rtos-tests/sys didnt work, ./docker-devel.sh "./phoenix-rtos-tests/runner.py --target armv7a9-zynq7000-qemu -t phoenix-rtos-tests/sys" had to be passed.

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (refactoring, style fixes, git/CI config, submodule management, no code logic changes)

How Has This Been Tested?

  • Already covered by automatic testing.
  • New test added: (add PR link here).
  • Tested by hand on: (list targets here).

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing linter checks and tests passed.
  • My changes generate no new compilation warnings for any of the targets.

Special treatment

  • This PR needs additional PRs to work (list the PRs, preferably in merge-order).
  • I will merge this PR by myself when appropriate.

Entrypoint in phoenixrtos/devel image is bash -l -c which passes
additional arguments to bash not to the program rum by bash.

JIRA: RTOS-952
@badochov badochov changed the title docker-devel.sh: pass arguments in double quotes !docker-devel.sh: pass arguments in double quotes Oct 16, 2024
Copy link

Unit Test Results

7 741 tests  ±0   7 026 ✅ ±0   39m 48s ⏱️ -10s
  461 suites ±0     715 💤 ±0 
    1 files   ±0       0 ❌ ±0 

Results for commit 152022a. ± Comparison against base commit a7f3fdb.

@nalajcie
Copy link
Member

seems like a good change, probably the non-interactive use case wasn't tested enough.
With this change I have trouble with "extra-escapes" but maybe there is no sensible use case for that?

Before the change:
image

After the change:
image

@badochov badochov merged commit 9e87a25 into master Oct 16, 2024
36 checks passed
@badochov badochov deleted the badochov/docker-devel branch October 16, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants