Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

requirements: add library to detect & reset USB devices #333

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

maska989
Copy link
Contributor

@maska989 maska989 commented Mar 7, 2024

JIRA: CI-249

Description

This python module gives access to backend of USB device pointed via VID and PID. Also, it gives access to completely reset device.

Motivation and Context

In case of use, phoenixd with 100% success rate on sparcv8leon3-gr716-mimas is needed to restart USB converter responsible for this connection. It will guarantee that buffer from either USB Converter and from Mimas will be clear. And without any additional options used by connection. (It may have additional value in case of targets like imxrt 117x nad 106x).

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

How Has This Been Tested?

  • Already covered by automatic testing.
  • New test added: (add PR link here).
  • Tested by hand on: (Experimental) sparcv8leon3-gr716-mimas.

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing linter checks and tests passed.
  • My changes generate no new compilation warnings for any of the targets.

Special treatment

  • This PR needs additional PRs to work (list the PRs, preferably in merge-order).
  • I will merge this PR by myself when appropriate.

Copy link

github-actions bot commented Mar 7, 2024

Unit Test Results

7 254 tests  ±0   6 543 ✅ ±0   37m 59s ⏱️ -14s
  408 suites ±0     711 💤 ±0 
    1 files   ±0       0 ❌ ±0 

Results for commit 127d16a. ± Comparison against base commit 609cb06.

♻️ This comment has been updated with latest results.

@mateusz-bloch
Copy link
Member

mateusz-bloch commented Mar 7, 2024

Have you tested if the approach with pyusb works with targets other than sparcv8leon3, and how it works ?

Copy link
Contributor

@damianloew damianloew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that we can simply write requirements: add pyusb and in the commit description explain shortly why it's needed. Otherwise LGTM

Library to detect & reset USB devices on targets.
JIRA: CI-249
Copy link
Member

@mateusz-bloch mateusz-bloch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mateusz-bloch mateusz-bloch merged commit 909cc0a into master Mar 12, 2024
30 checks passed
@mateusz-bloch mateusz-bloch deleted the maska989/mimas_requirements branch March 12, 2024 14:48
@damianloew
Copy link
Contributor

LGTM

I've suggested to explain why it's needed in the commit description - not a quick description of an added tool. I meant sth like: Required for a proper sparc target restart

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants