test_mprotect: test if mprotected pages are copied #381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 tasks
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
badochov
force-pushed
the
badochov/mprotect-shared
branch
from
82db1e7
to
4550a98
Compare
|
DRAFTING: as demo showed issue on ia32, weird that only on one platform there's an issue with this change |
agkaminski
reviewed
Oct 17, 2024
Comment on lines
+85
to
+88
| sleep(1); | ||
| if (area[0] != 0x42) { | ||
| exit(1); | ||
| } |
There was a problem hiding this comment.
Perhaps it might be easier to do this test in reverse - modify the memory in child instead. This would be nicer, as it would only require waitpid sync point, without sleep. But I'm not 100% sure that such approach would test exactly the same thing
There was a problem hiding this comment.
I'll add separate test case for that
pages_in_child_copied test checks if pages with protection changed to read from read-write by mprotect are copied by child. pages_in_parent_copied test checks if pages with protection changed to read from read-write by mprotect are copied by parent. JIRA: RTOS-953
badochov
force-pushed
the
badochov/mprotect-shared
branch
from
4550a98
to
2ff2ee7
Compare
agkaminski
approved these changes
Oct 17, 2024
badochov
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pages_in_child_copied test checks if pages with protection changed to read from read-write by mprotect are copied by child.
JIRA: RTOS-953
Description
Motivation and Context
Types of changes
How Has This Been Tested?
Checklist:
Special treatment
map: fix mprotected pages not being copied phoenix-rtos-kernel#608