Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rtt: Improve buffer allocation and handling #351

Merged
merged 2 commits into from
Sep 27, 2024
Merged

Conversation

jmaksymowicz
Copy link
Contributor

@jmaksymowicz jmaksymowicz commented Sep 19, 2024

Description

Corrected memory mappings for imxrt devices, which could result in data being placed out of bounds of dtcm memory.
Added support for passing RTT details through syspage on imxrt.
Reserved dedicated memory for RTT in memory maps.

Motivation and Context

This allows RTT buffers to be allocated at compile time and remain available after kernel is started. This also removes hard-coded RTT address, which reduces confusion when using different memory configurations.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (refactoring, style fixes, git/CI config, submodule management, no code logic changes)

How Has This Been Tested?

  • Already covered by automatic testing.
  • New test added: (add PR link here).
  • Tested by hand on: imxrt1170

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing linter checks and tests passed.
  • My changes generate no new compilation warnings for any of the targets.

Special treatment

  • This PR needs additional PRs to work
  • I will merge this PR by myself when appropriate.

Copy link

github-actions bot commented Sep 26, 2024

Unit Test Results

7 723 tests  ±0   7 008 ✅ ±0   37m 28s ⏱️ +5s
  443 suites ±0     715 💤 ±0 
    1 files   ±0       0 ❌ ±0 

Results for commit c2e8bfe. ± Comparison against base commit 23534d2.

♻️ This comment has been updated with latest results.

@jmaksymowicz jmaksymowicz force-pushed the jmaksymowicz/RTOS-754 branch 3 times, most recently from 2a2b8e4 to 84bfdc3 Compare September 26, 2024 12:39
ld/armv7m4-stm32l4x6.ldt Outdated Show resolved Hide resolved
Fix mapping origin on imxrt117x.
Fix mapping length on imxrt106x, imxrt105x.

JIRA: RTOS-754
@Darchiv Darchiv merged commit ebd4d55 into master Sep 27, 2024
34 checks passed
@Darchiv Darchiv deleted the jmaksymowicz/RTOS-754 branch September 27, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants