Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

devices/pipe-rtt: Properly handle timeout in RTT reads #363

Merged
merged 1 commit into from
Oct 16, 2024
Merged

devices/pipe-rtt: Properly handle timeout in RTT reads #363

merged 1 commit into from
Oct 16, 2024

Conversation

Darchiv
Copy link
Member

@Darchiv Darchiv commented Oct 16, 2024

This change fixes the problem of plo's wait command not waiting while using RTT console. Read operation was completed immediately instead of blocking for at least timeout.

JIRA: NIL-596

Description

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (refactoring, style fixes, git/CI config, submodule management, no code logic changes)

How Has This Been Tested?

  • Already covered by automatic testing.
  • New test added: (add PR link here).
  • Tested by hand on: imxrt1170-evk

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing linter checks and tests passed.
  • My changes generate no new compilation warnings for any of the targets.

Special treatment

  • This PR needs additional PRs to work (list the PRs, preferably in merge-order).
  • I will merge this PR by myself when appropriate.

@Darchiv
devices/pipe-rtt: Properly handle timeout in RTT reads
6de8cec 
This change fixes the problem of plo's `wait` command not waiting while
using RTT console. Read operation was completed immediately instead of
blocking for at least `timeout`.

JIRA: NIL-596
@Darchiv Darchiv requested a review from anglov October 16, 2024 17:38
@Darchiv Darchiv marked this pull request as ready for review October 16, 2024 17:38
anglov
anglov approved these changes Oct 16, 2024
View reviewed changes
Copy link
Member

@anglov anglov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Darchiv Darchiv merged commit 6faf84b into master Oct 16, 2024
34 of 35 checks passed
@Darchiv Darchiv deleted the Darchiv/NIL-596 branch October 16, 2024 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anglov anglov anglov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Darchiv @anglov