Verifies npm package tarball authenticity and integrity #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grzuy
commented
Oct 10, 2023
josevalim
reviewed
Oct 10, 2023
josevalim
reviewed
Oct 10, 2023
|
Pending adding a few test cases. Waiting to see if added here or in separate package. |
Co-authored-by: José Valim <jose.valim@gmail.com>
Co-authored-by: José Valim <jose.valim@gmail.com>
josevalim
reviewed
Oct 10, 2023
josevalim
reviewed
Oct 10, 2023
josevalim
reviewed
Oct 10, 2023
Co-authored-by: José Valim <jose.valim@gmail.com>
josevalim
reviewed
Oct 10, 2023
lib/npm_registry.ex
Outdated
| require Logger | ||
|
|
||
| @base_url "https://registry.npmjs.org" | ||
| @public_key_pem File.read!("npm-registry.pem") |
There was a problem hiding this comment.
please move the file to lib/esbuild/npm-registry.pem and also add this:
@external_resource "lib/esbuild/npm-registry.pem"
This will recompile the code and if pem file changes. :)
There was a problem hiding this comment.
This will recompile the code and if pem file changes. :)
TIL 😮 👏
|
Beautifully done, thank you! |
|
Will take a look at the CI issue with elixir 11. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #42