Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test on PHP 8.3 and 8.4 #267

Merged
merged 1 commit into from
Oct 2, 2024
Merged

Test on PHP 8.3 and 8.4 #267

merged 1 commit into from
Oct 2, 2024

Conversation

GrahamCampbell
Copy link
Contributor

@GrahamCampbell GrahamCampbell commented Sep 30, 2024

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Related tickets N/A
Documentation N/A
License MIT

What's in this PR?

Runs CI on both PHP 8.3 and 8.4.

Why?

To validate compatibility.

Example Usage

N/A

Checklist

  • Updated CHANGELOG.md to describe BC breaks / deprecations | new feature | bugfix
  • Documentation pull request created (if not simply a bugfix)

To Do

  • If the PR is not complete but you want to discuss the approach, list what remains to be done here

@GrahamCampbell
Copy link
Contributor Author

Build failures are not related, and should be addressed in a separate PR. Indeed, we need to turn off the PHP 7 incompatible changes that php-cs-fixer is suggesting.

@dbu
Copy link
Contributor

dbu commented Oct 2, 2024

i changed the cs fixer rules to not require trailing_comma_in_multiline for now

i guess we eventually want to ditch php 7 support and enable the rule...

@dbu dbu merged commit 215a71f into php-http:1.x Oct 2, 2024
30 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants