GitHub Actions for testing, and automatic phar creation

[roelofr]

Depends on #45, test results are available at roelofr:#1, which merge into that master branch.

I'm still seeing errors on this branch, very wierd ones at that:

Fatal error: Interface 'JsonSerializable' not found in /home/runner/work/php-parallel-lint/php-parallel-lint/src/Error.php on line 4

I don't know why, but the Json class seems unavailable, although the json extension is enabled.

On PHP 8.0 I even saw Fatal error: Uncaught Error: Call to undefined function token_get_all(), which is a built-in and should always work.

Some wierd stuff going on here... 🤔

Will close #44.

[roelofr]

Thanks for the review, I've been recycling the same build file over and over, it's time to freshen it up 😃

[deatharse]

Would like to suggest a step after generating the phar file to test it before uploading as an asset. Checking the return code of -h as a minimum.

#42 Highlights current issues building the phar file, but successful compilation of the phar does not guarantee a usable phar file.

[jrfnl]

@alasdairdc Good idea. Could be as simple as using the phar to run parallel-lint over the repo code, I suppose.

[deatharse]

@jrfnl That would work.

[jrfnl]

As there are a couple of open PRs, it would be great to get CI running again, as, knowing how many projects use this package, it is kind of irresponsible to merge functional changes without it.

With that in mind, I think the order of PRs needs to be changed and the GH Actions part of this PR needs to be merged before #45 can be. /cc @grogy

@roelofr Do you have time to continue work on this ? If not, I'd be happy to continue where you left off and get an initial GH Actions workflow up & running ready for merge.

[grogy]

What about cherry-pick part of .github/workflows/test.yml to master? Phar release and next changes will be checked with GH Actions and will be safe. @jrfnl

[roelofr]

I updated the codebase to test the phar on all versions, but compile it on php 5.4.

I'm still having an issue with the unit tests but other than that, all checks are executed.

[glensc]

I'm still having an issue with the unit tests but other than that, all checks are executed.

you are missing ext-tokenizer add tokenizer to this line:

https://github.com/roelofr/php-parallel-lint/blob/0b58fde087c4aa7ed9271d8f7d763d1c022740a6/.github/workflows/release.yml#L21

[roelofr]

Thanks! That did it

[grogy]

Great, now it look's complete. Thank you @roelofr and reviewers @glensc and @jrfnl

[jrfnl]

Sorry, I never got round to doing a review of the updated workflow.

I've just looked at it now and most of the test runs have disappeared somewhere along the way. I will send in a PR to fix this up.