Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ErrorFormatter: support PHP Console Highlighter 1.0.0 #92

Merged
merged 1 commit into from
Feb 21, 2022
Merged

ErrorFormatter: support PHP Console Highlighter 1.0.0 #92

merged 1 commit into from
Feb 21, 2022

Conversation

jrfnl
Copy link
Collaborator

@jrfnl jrfnl commented Feb 18, 2022

PHP Console Highlighter 1.0.0 has just been released.

This PR adds cross-version support for both PHP Console Highlighter < 1.0.0 and 1.0.0+ to PHP Parallel Lint, which allows people to update the Highlighter dependency to the latest version.

Includes changelog entry to allow this PR to still be included in the 1.3.2 release.

Ref: https://github.com/php-parallel-lint/PHP-Console-Highlighter/releases/tag/v1.0.0

@jrfnl jrfnl added this to the 1.3.2 milestone Feb 18, 2022
@jrfnl jrfnl requested a review from grogy February 18, 2022 12:30
@jrfnl jrfnl mentioned this pull request Feb 18, 2022
Merged
@jrfnl jrfnl force-pushed the feature/highlighter-cross-version-compat branch 3 times, most recently from 3959ec5 to 7bef99d Compare February 19, 2022 05:27
@jrfnl
ErrorFormatter: support PHP Console Highlighter 1.0.0
d5b30a7 
PHP Console Highlighter 1.0.0 has just been released.

This PR adds cross-version support for both PHP Console Highlighter < 1.0.0 and 1.0.0+ to PHP Parallel Lint, which allows people to update the Highlighter dependency to the latest version.

Includes changelog entry to allow this PR to be included in the 1.3.2 release.

Ref: https://github.com/php-parallel-lint/PHP-Console-Highlighter/releases/tag/v1.0.0
@jrfnl jrfnl force-pushed the feature/highlighter-cross-version-compat branch from 7bef99d to d5b30a7 Compare February 19, 2022 05:30
@jrfnl
Copy link
Collaborator Author

jrfnl commented Feb 21, 2022

@grogy Would be great if this PR could be merged so 1.3.2 can be released. 🙏🏻 Thanks!

@grogy
Copy link
Member

grogy commented Feb 21, 2022

Thank you, it looks good :-)

@grogy grogy merged commit 6483c98 into master Feb 21, 2022
@grogy grogy deleted the feature/highlighter-cross-version-compat branch February 21, 2022 12:50
@jrfnl
Copy link
Collaborator Author

jrfnl commented Feb 21, 2022

Thanks @grogy. You okay with me tagging 1.3.2 now ?

@grogy
Copy link
Member

grogy commented Feb 21, 2022

Yes, I agree. You will create "intro" message for new version? When yes, than I suggest

New version support PHP 8.1, is again tested against PHP 5.3 and we welcome @jrfnl as maintainer.

v1.3.1...HEAD

@jrfnl
Copy link
Collaborator Author

jrfnl commented Feb 21, 2022

What do you mean by intro message ? And how do you normally do this ?

I thought it was a case of tagging the last commit, pushing the tag to GH, then the release workflow will create the Draft release and I add the changelog to it from the other PR ?

@grogy
Copy link
Member

grogy commented Feb 21, 2022

I mean one sentence before contain from changelog.

Example:

New version support PHP 8.1, is again tested against PHP 5.3 and we welcome @jrfnl as maintainer.


### Added

- Support for PHP Console Highlighter 1.0.0, which comes with PHP Console Color 1.0.1, [#92] from [@jrfnl].

### Fixed

- Bug fix: make Phar file run independently of project under scan [#63] from [@jrfnl], fixes [#61].
- Bug fix: checkstyle report could contain invalid XML due to insufficient output escaping [#73] from [@gmazzap], fixes [#72].
- Fix Phar building [#70] from [@jrfnl]. This fixes PHP 8.1 compatibility for the Phar file.
- Documentation fix: the `--show-deprecated` option was missing in both the README as well as the CLI `help` [#84] from [@jrfnl], fixes [#81] reported by [@stronk7].

### Changed

- README: updated information about PHAR availability [#77] from [@jrfnl].
.......

@jrfnl
Copy link
Collaborator Author

jrfnl commented Feb 21, 2022

Ah, in the release notes ? Or do you use annotated tags ?

@jrfnl
Copy link
Collaborator Author

jrfnl commented Feb 21, 2022

I've used an annotated tag now. Fingers crossed I've done it correctly.

@grogy
Copy link
Member

grogy commented Feb 21, 2022

Perfect 🚀

@jrfnl jrfnl mentioned this pull request Feb 21, 2022
Merged
@php-parallel-lint php-parallel-lint deleted a comment from onu11 Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grogy grogy Awaiting requested review from grogy

Assignees
No one assigned
Labels
Type: enhancement
Milestone
1.3.2
Development

Successfully merging this pull request may close these issues.
2 participants
@jrfnl @grogy