Run all services on port 8080 for Google App Engine compatibility #14
+24
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EricTendian
reviewed
Sep 16, 2018
| ARGS='--port 8080' | ||
| trapIt /ppm/vendor/bin/ppm start --ansi $@ |
There was a problem hiding this comment.
Doesn't $ARGS need to be passed in here?
stepanselyuk
added a commit
to redlotus-corp/php-pm-docker
that referenced
this pull request
Aug 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After submitting #13, I decided to write a quick PR that makes php-pm-docker listen on port 8080 by default.
I also updated all the references in README.md.