Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weird behaviour after doctrine-bundle update 2.0.6 #161

Open
acasademont opened this issue Dec 23, 2019 · 6 comments
Open

Weird behaviour after doctrine-bundle update 2.0.6 #161

acasademont opened this issue Dec 23, 2019 · 6 comments

Comments

@acasademont
Copy link
Contributor

Just to keep track of it, seems like the new doctrine-bundle default behaviour interferes with our clear or reset strategy we have in the Symfony bootstrap.

doctrine/DoctrineBundle#1114

@dnna
Copy link
Contributor

dnna commented Dec 23, 2019

That looks strange indeed. I'll try to have a look in the next few days, as this will probably affect my projects as well after upgrading. The PHP-PM code itself doesn't look wrong, it only resets if the entity manager is not open (e.g. an exception occurred that closed it), otherwise it only clears the existing one.

@dnna
Copy link
Contributor

dnna commented Dec 23, 2019

Btw, if DoctrineBundle now performs its own reset we should probably remove our reset logic in PHP-PM's postHandle or make it conditional on Doctrine\Bundle\DoctrineBundle\Registry not having ResetInterface. Otherwise we are resetting twice now.

@acasademont
Copy link
Contributor Author

yes, exactly, it's as easy as to check if the doctrine service is implementing the ResetInterface or not

@mathieudz
Copy link
Contributor

I'm having memory leaks after upgrading from doctrine-bundle 2.0.2 to 2.0.6. Workers reach max memory after 500 requests while the workers are only restarted after 1000 requests. I've downgraded it back to 2.0.2

@acasademont
Copy link
Contributor Author

acasademont commented Dec 25, 2019 via email

@acasademont
Copy link
Contributor Author

@mathieudz didn't see any memory limit crashes on our logs. Still, we should also keep an eye on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants