Don't reset Registry if it implements ResetInterface #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM /cc @acasademont |
|
Totally +1. I still need to investigate the causes of doctrine/DoctrineBundle#1114 though and try to understand why are they are always resetting the EM instead of just clearing as we do (except when the EM has been closed) |
|
CI is broken due to version mismatch, but thats a separate topic. Need to find out if its due to travis composer cache or a real problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aside from the other issues DoctrineBundle 2.0.6 introduced, it also results in resetting the entity manager twice on every request (one reset is done from Symfony and the other one from us).
This PR prevents this behavior by checking whether the
RegistryimplementsResetInterfaceand not executing our reset if it does.