resend requests that returns http error #240
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometime for temporary issue, shopify http request fail, for example I found in my test logs:
If you try again a moment later, same requests are ok.
This implementation try to mitigate this problem.
I add a configuration parameters
RequestRetryCallback
that allow to define a callback to manage or log the retry.The callback take 3 input parameter: raw curl response, exception object and retry number.
If this callback return true (or non null value) another attempt will be performed.
By default this callback is not defined and this does not change the original behavior of the library.
For example
This is a modified version of #234 after @tareqtms advice.