Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use GitHub-hosted macOS runners #78

Merged
merged 4 commits into from
Jul 8, 2024
Merged

ci: use GitHub-hosted macOS runners #78

merged 4 commits into from
Jul 8, 2024

Conversation

maxrake
Copy link
Contributor

@maxrake maxrake commented Jul 8, 2024

The GitHub-hosted macOS runners have been updated to include arm64 M1 options now. This PR switches our workflows to use them instead of the self-hosted runner. There is more availability for these runners and they run just about as fast, if not faster when accounting for parallel jobs. The workflow was updated to change macos-latest to macos-14 to be specific about the version in the matrix and allow for adding additional versions in the future.

Resources:

@maxrake maxrake self-assigned this Jul 8, 2024
Copy link
Contributor

@kylewillmon kylewillmon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should use macos-latest instead of macos-14 to avoid having to update it later

.github/workflows/test.yml Outdated Show resolved Hide resolved
.github/workflows/test.yml Outdated Show resolved Hide resolved
@kylewillmon
Copy link
Contributor

While you're updating this workflow, can you also remove the use of actions-rs/toolchain? That action has not been updated in years and the repository is archived.

The alternatives are dtolnay/rust-toolchain or simply running rustup.

* Remove the `target` option from the test matrix
* Install the Rust toolchain with `rustup` directly instead of an action
* Ensure each test command references the expected toolchain explicitly
@maxrake maxrake requested a review from kylewillmon July 8, 2024 20:44
@maxrake maxrake merged commit f3c0e17 into main Jul 8, 2024
6 checks passed
@maxrake maxrake deleted the macos_latest branch July 8, 2024 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants