Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecation warning for extending a compound selector #356

Closed
bertmelis opened this issue Dec 7, 2017 · 1 comment
Closed

deprecation warning for extending a compound selector #356

bertmelis opened this issue Dec 7, 2017 · 1 comment
Labels

Comments

@bertmelis
Copy link

When importing Spectre into my css via Sass, I get a deprecation warning:

 DEPRECATION WARNING on line 22 of <full path>/_sass/spectre/mixins/_button.scss:
Extending a compound selector, .btn-primary.loading, is deprecated and will not be supported in a future release.
See https://github.com/sass/sass/issues/1599 for details.

My knowledge of Sass is zero to none and my css is aged, so I'm the guy that can solve this one.

@picturepan2
Copy link
Owner

@bertmelis I think it is related to @extend and compound selectors. The affected code is:

  &.loading {
    @extend .btn-primary.loading;
  }

I am looking into the issue though the Spectre code is fine.

@bertmelis bertmelis changed the title deprecatino warning for extending a compound selector deprecation warning for extending a compound selector Dec 13, 2017
picturepan2 added a commit that referenced this issue Feb 18, 2018
@picturepan2 picturepan2 mentioned this issue Feb 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants