Enable LDAC in the build #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Permit LDAC to be enabled independenly of LHDC Fix a bug/oversight in bt_sbc_player which caused system frequencies above 52M to be ignored
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BTIF_AVDTP_CODEC_TYPE_NON_A2DPpath and need a buffer bigger than 102400)bt_sbc_playerwhich caused system frequencies above 52M to be ignored (LDAC seems to target a 96k sample rate by default and thus needs 104M, as specified here and here.)I'm not sure if the line was originally added for debug purposes (git blame traces it back to the initial commit, you can see it here), so its possible that the hunk at services/bt_app/app_bt_stream.cpp#3869 could be removed entirely, or that my version may unnecessarily increase power usage in certain scenarios
I've tested it against my Xperia 1 V in both "Best effort" and "Sound quality preferred" modes and it seems to function without issues