This repository has been archived by the owner on Jul 24, 2024. It is now read-only.
cherry-pick important features to release-4.0 branch #622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix: backup will skip empty databases. * fix typo. Co-authored-by: 山岚 <36239017+YuJuncen@users.noreply.github.com> Co-authored-by: 3pointer <luancheng@pingcap.com> Co-authored-by: kennytm <kennytm@gmail.com>
|
LGTM |
|
Please update kvproto to latest release-4.0 |
|
overvenus
reviewed
Nov 27, 2020
go.mod
Outdated
| @@ -4,35 +4,43 @@ go 1.13 | |||
|
|
|||
| require ( | |||
go.mod1
Outdated
| github.com/prometheus/client_golang v1.5.1 | ||
| github.com/prometheus/common v0.9.1 | ||
| github.com/sirupsen/logrus v1.6.0 | ||
| github.com/spf13/cobra v1.0.0 | ||
| github.com/spf13/pflag v1.0.5 | ||
| github.com/tikv/pd v1.1.0-beta.0.20200910042021-254d1345be09 | ||
| github.com/syndtr/goleveldb v1.0.1-0.20190625010220-02440ea7a285 // indirect |
There was a problem hiding this comment.
Please remove indirect dependencies.
pkg/conn/conn.go
Outdated
Comment on lines
21
to
23
| "google.golang.org/grpc/keepalive" | ||
|
|
||
| "github.com/pingcap/kvproto/pkg/backup" |
There was a problem hiding this comment.
Suggested change
| "google.golang.org/grpc/keepalive" | |
| "github.com/pingcap/kvproto/pkg/backup" | |
| "google.golang.org/grpc/keepalive" | |
| "github.com/pingcap/kvproto/pkg/backup" |
|
/rebuild |
ti-srebot
approved these changes
Nov 27, 2020
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Some PRs are not cherry-picked to release-4.0.
What is changed and how it works?
cherry-pick important features to release-4.0 branch
Check List
Tests
Release Note