Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

Didn't fully support sync view while remove view from builtin skip DDLs #1300

Closed
lance6716 opened this issue Nov 25, 2020 · 10 comments · May be fixed by #1310
Closed

Didn't fully support sync view while remove view from builtin skip DDLs #1300

lance6716 opened this issue Nov 25, 2020 · 10 comments · May be fixed by #1310
Assignees
Labels
type/feature-request This issue is a feature request

Comments

@lance6716
Copy link
Collaborator

Bug Report

Please answer these questions before submitting your issue. Thanks!

  1. What did you do? If possible, provide a recipe for reproducing the error.

create view in upstream

  1. What did you expect to see?

  2. What did you see instead?

error 11007 unknown type DDL

  1. Versions of the cluster

    • DM version (run dmctl -V or dm-worker -V or dm-master -V):

      master

@lance6716 lance6716 added severity/major type/bug This issue is a bug report labels Nov 25, 2020
@lance6716
Copy link
Collaborator Author

in #1105 we allow syncing of CREATE VIEW, but didn't add an integration test (unit test didn't expose the problem, which maybe SplitDDL can't handle VIEW)

@lance6716
Copy link
Collaborator Author

since we didn't dump&load view, how about still filter out VIEW in sync 😂

@csuzhangxc
Copy link
Member

since we didn't dump&load view, how about still filter out VIEW in sync 😂

or add support for dump&load view?

@lance6716
Copy link
Collaborator Author

since we didn't dump&load view, how about still filter out VIEW in sync 😂

or add support for dump&load view?

OK, will learn from pingcap/tidb-lightning#417. I'm not sure this could be finished in coming release 😂

@lichunzhu
Copy link
Contributor

Just load views after all the tables have been loaded. Dumpling has already supported dumping views like mydumper pingcap/dumpling#158

@cyliu0
Copy link

cyliu0 commented Nov 26, 2020

A community user is questioning about dm supporting view yesterday. So this could be a customer issue in some cases.

@glkappe
Copy link

glkappe commented Nov 30, 2020

@lance6716 How is the progress of this issue?

@lance6716
Copy link
Collaborator Author

lance6716 commented Nov 30, 2020

@lance6716 How is the progress of this issue?

above this comment is a pull request that fixes this issue. if it gets reviewed quickly, this could be supported in nightly this week (but not well tested).

@lance6716 lance6716 added type/feature-request This issue is a feature request and removed severity/major type/bug This issue is a bug report labels Dec 18, 2020
@lance6716
Copy link
Collaborator Author

block syncing of VIEW in #1331 and will support it later. changed to feature-request

@lance6716
Copy link
Collaborator Author

repalced by #1622

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type/feature-request This issue is a feature request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants