Skip to content
This repository has been archived by the owner on Aug 21, 2023. It is now read-only.

make dumpling support dumping view #158

Merged
merged 7 commits into from
Sep 30, 2020
Merged

Conversation

lichunzhu
Copy link
Contributor

What problem does this PR solve?

close #93

What is changed and how it works?

support dumping views like mydumper.

Check List

Tests

  • Unit test

Related changes

  • Need to cherry-pick to the release branch

Release note

  • No release note

Copy link
Collaborator

@kennytm kennytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest LGTM

v4/export/sql.go Outdated Show resolved Hide resolved
@kennytm kennytm added status/LGT1 One reviewer approved (LGTM1) and removed status/PTAL labels Sep 30, 2020
@kennytm kennytm merged commit 5129591 into pingcap:master Sep 30, 2020
@lichunzhu lichunzhu deleted the supportDumpView branch October 5, 2020 14:22
tisonkun pushed a commit to tisonkun/dumpling that referenced this pull request Oct 20, 2021
* support dump view

* add unit tests

* add more comments

* fix integration tests

* address comment

* fix
tisonkun pushed a commit to tisonkun/dumpling that referenced this pull request Oct 20, 2021
* support dump view

* add unit tests

* add more comments

* fix integration tests

* address comment

* fix
tisonkun pushed a commit to tisonkun/dumpling that referenced this pull request Oct 20, 2021
* support dump view

* add unit tests

* add more comments

* fix integration tests

* address comment

* fix
tisonkun pushed a commit to tisonkun/dumpling that referenced this pull request Oct 20, 2021
* support dump view

* add unit tests

* add more comments

* fix integration tests

* address comment

* fix
tisonkun pushed a commit to tisonkun/tidb that referenced this pull request Oct 20, 2021
* support dump view

* add unit tests

* add more comments

* fix integration tests

* address comment

* fix
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status/LGT1 One reviewer approved (LGTM1)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to dump views?
2 participants