Skip to content
This repository has been archived by the owner on Sep 13, 2022. It is now read-only.

Ent hello world #81

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Ent hello world #81

wants to merge 10 commits into from

Conversation

hedwigz
Copy link

@hedwigz hedwigz commented May 3, 2022

First-time contributors' checklist

What is changed, added or deleted? (Required)

Added dev docs example for Entgo, since it now officially supports TiDB :)

Which TiDB version(s) do your changes apply to? (Required)

5.4.0, 6.0.0

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases

@ti-chi-bot
Copy link
Member

ti-chi-bot commented May 3, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Oreoxmt
  • lance6716

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added contribution first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. labels May 3, 2022
@ti-chi-bot
Copy link
Member

Welcome @hedwigz!

It looks like this is your first PR to pingcap/docs-appdev 🎉.

I'm the bot to help you request reviewers, add labels and more, See available commands.

We want to make sure your contribution gets all the attention it needs!



Thank you, and welcome to pingcap/docs-appdev. 😃

en/for-ent.md Outdated Show resolved Hide resolved
en/for-ent.md Outdated Show resolved Hide resolved
Amit Shani and others added 2 commits May 3, 2022 11:37
Co-authored-by: MasseElch <12862103+masseelch@users.noreply.github.com>
Co-authored-by: MasseElch <12862103+masseelch@users.noreply.github.com>
@TomShawn TomShawn requested review from bb7133 and hawkingrei May 5, 2022 03:30
en/for-ent.md Outdated Show resolved Hide resolved
@hedwigz hedwigz requested a review from hawkingrei May 8, 2022 07:07
@hedwigz hedwigz requested a review from hawkingrei May 24, 2022 12:43
@hedwigz
Copy link
Author

hedwigz commented Jun 7, 2022

Hey @hawkingrei what's missing for this to be merged? 🙏

@ti-chi-bot
Copy link
Member

@hawkingrei: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@hawkingrei
Copy link
Member

/can-merge

@lance6716
Copy link

/merge

@ti-chi-bot
Copy link
Member

@lance6716: /merge in this pull request requires 2 approval(s).

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@Icemap
Copy link
Member

Icemap commented Sep 9, 2022

Hello @hedwigz, we no longer include this library as part of the official PingCAP documentation.
Can I add ent to the list of Supported Third-party ORMs here instead of this PR?

@Icemap
Copy link
Member

Icemap commented Sep 9, 2022

/cc @Oreoxmt

@Oreoxmt
Copy link
Contributor

Oreoxmt commented Sep 9, 2022

/merge

@Icemap @hedwigz I have merged this PR. To add ent as a TiDB supported third-party ORM, we can do further discussions in this PR.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: bb5f058

@masseelch
Copy link

Hey @Oreoxmt and @Icemap, I am one of the Ent maintainers and am answering on the behalf of @hedwigz.

Can I add ent to the list of Supported Third-party ORMs here instead of this PR?

Yes, let's add it there as well. Do you need something specific from me for this?

@Icemap
Copy link
Member

Icemap commented Sep 9, 2022

@masseelch The current information is sufficient. And thanks a lot to ent for the PR. You guys are doing great work.

@lance6716
Copy link

kindly remind that CI is not working

@Icemap
Copy link
Member

Icemap commented Sep 9, 2022

Add ent to Supported Third-party ORMs PR: 中文 / English

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
contribution first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. missing-translation-status size/L status/can-merge status/LGT2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants