-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tools: add description for monitor #1052
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lilin90
changed the title
add description for monitor
tools: add description for monitor
Dec 19, 2018
lilin90
reviewed
Dec 19, 2018
@july2993 PTAL. Thanks! |
lilin90
reviewed
Dec 21, 2018
lilin90
added a commit
to lilin90/docs
that referenced
this pull request
Dec 21, 2018
Co-Authored-By: WangXiangUSTC <xiang13225080@163.com>
Co-Authored-By: WangXiangUSTC <xiang13225080@163.com>
Co-Authored-By: WangXiangUSTC <xiang13225080@163.com>
Co-Authored-By: WangXiangUSTC <xiang13225080@163.com>
july2993
approved these changes
Dec 24, 2018
lilin90
approved these changes
Dec 24, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
lilin90
added a commit
to pingcap/docs
that referenced
this pull request
Dec 24, 2018
* tools: add TiDB-Binlog monitoring metrics Via: pingcap/docs-cn#1052 * tools: update wording * tools: add a download tip about Pump and Drainer * tools: update wording
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.