Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimizer-fix-control: add doc for the new optimizer fix controls introduced in v7.3.0 #14535

Merged
merged 11 commits into from
Aug 7, 2023

Conversation

time-and-fate
Copy link
Member

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v7.3 (TiDB 7.3 versions)
  • v7.2 (TiDB 7.2 versions)
  • v7.1 (TiDB 7.1 versions)
  • v7.0 (TiDB 7.0 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 17, 2023
@ran-huang ran-huang added for-release This PR relates to a TiDB release but does not have a tracked feature. v7.3 This PR/issue applies to TiDB v7.3. translation/doing This PR’s assignee is translating this PR. labels Jul 18, 2023
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label Jul 18, 2023
optimizer-fix-controls.md Outdated Show resolved Hide resolved
optimizer-fix-controls.md Outdated Show resolved Hide resolved
optimizer-fix-controls.md Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jul 19, 2023
Co-authored-by: Ran <huangran.alex@gmail.com>
@ran-huang ran-huang requested a review from qw4990 July 20, 2023 03:06
@ran-huang ran-huang added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed translation/doing This PR’s assignee is translating this PR. labels Jul 20, 2023
@ran-huang ran-huang requested a review from qiancai July 21, 2023 03:58
optimizer-fix-controls.md Outdated Show resolved Hide resolved
optimizer-fix-controls.md Outdated Show resolved Hide resolved
optimizer-fix-controls.md Outdated Show resolved Hide resolved
ran-huang and others added 3 commits July 27, 2023 16:15
Co-authored-by: Grace Cai <qqzczy@126.com>
Co-authored-by: Grace Cai <qqzczy@126.com>
Co-authored-by: Grace Cai <qqzczy@126.com>
@ran-huang ran-huang requested a review from qiancai July 27, 2023 08:16
Co-authored-by: Grace Cai <qqzczy@126.com>
@ran-huang ran-huang requested a review from qiancai August 1, 2023 07:59
@ran-huang
Copy link
Contributor

/verify

@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 7, 2023

@qw4990: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 7, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 7, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-07-19 03:34:36.607962857 +0000 UTC m=+1080568.378301565: ☑️ agreed by ran-huang.
  • 2023-08-07 06:29:32.119147664 +0000 UTC m=+685256.061496191: ☑️ agreed by qiancai.

@ran-huang ran-huang removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 7, 2023
@ran-huang
Copy link
Contributor

/approve

@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 7, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ran-huang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Aug 7, 2023
@ti-chi-bot ti-chi-bot bot merged commit 22a965d into pingcap:master Aug 7, 2023
4 checks passed
@qiancai qiancai mentioned this pull request Jan 5, 2024
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved for-release This PR relates to a TiDB release but does not have a tracked feature. lgtm size/S Denotes a PR that changes 10-29 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. v7.3 This PR/issue applies to TiDB v7.3.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants