how-to/monitor: update manual deploy monitor #1965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lilin90
changed the title
lilin90
added
translation/doing
lilin90
reviewed
Oct 21, 2019
There was a problem hiding this comment.
- The changes in this PR is different from that comment in Is there a file tivk_pull.json? tidb-ansible#999. Please check whether we need to add all JSON files mentioned in that comment. For example,
tikv_trouble_shooting.jsonis missing. - The
best-practiceslabel only applies to best practice articles. This is not one, so you don't need to add that label.
lilin90
reviewed
Oct 21, 2019
Co-Authored-By: Lilian Lee <lilin@pingcap.com>
Co-Authored-By: Lilian Lee <lilin@pingcap.com>
You are right, |
|
@liubo0127 I think you might need a technical review? |
lilin90
approved these changes
Oct 23, 2019
lilin90
reviewed
Oct 23, 2019
Co-Authored-By: Lilian Lee <lilin@pingcap.com>
Co-Authored-By: Lilian Lee <lilin@pingcap.com>
anotherrachel
added
translation/done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is changed, added or deleted?
Update the dashboard file for manual deploy monitor. In master or 3.0, some file does not exist.
What is the related PR or file link(s)?
pingcap/tidb-ansible#999
#1962
Which version does your change affect?
Affects TiDB master and 3.0.