Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

readme, contributing: rewrite and reorganize contribution resources #2017

Merged
merged 14 commits into from
Feb 14, 2020

Conversation

lilin90
Copy link
Member

@lilin90 lilin90 commented Nov 6, 2019

What is changed, added or deleted?

  • Rewrite README.md to make it more like a docs readme (replace simply intro to TiDB)
  • CONTRIBUTING.md updates
    • Add more resources
    • Convert the list of 26 markdownlint rules to a table (more friendly for users to read only the Chinese explanation)
    • Reorganize the items of markdownlint rules to make it more logical in content (such as keeping titles rules together)
  • Update inappropriate and obsolete links in README.md and CONTRIBUTING.md

What is the related PR or file link(s)?

N/A

Which version does your change affect?

N/A

@lilin90 lilin90 added the translation/doing This PR’s assignee is translating this PR. label Nov 6, 2019
@lilin90 lilin90 self-assigned this Nov 6, 2019
@lilin90 lilin90 marked this pull request as ready for review February 14, 2020 02:29
@lilin90 lilin90 requested a review from yikeke February 14, 2020 02:29
@lilin90 lilin90 changed the title readme: rewrite to add docs description [WIP]readme: rewrite to add docs description Feb 14, 2020
@lilin90 lilin90 changed the title [WIP]readme: rewrite to add docs description readme: rewrite to add docs description Feb 14, 2020
@lilin90
Copy link
Member Author

lilin90 commented Feb 14, 2020

@yikeke PTAL~ @dcalvin FYI.

@lilin90 lilin90 changed the title readme: rewrite to add docs description readme, contributing: rewrite and reorganize contribution resources Feb 14, 2020
@lilin90 lilin90 added the size/large Changes of a large size. label Feb 14, 2020
Copy link
Contributor

@yikeke yikeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

| 5 | [MD023 - Headings must start at the beginning of the line](https://github.com/DavidAnson/markdownlint/blob/master/doc/Rules.md#md023---headings-must-start-at-the-beginning-of-the-line) | 标题必须出现在一行行首,即标题的 `#` 号前不能有任何空格。 |
| 6 | [MD026 - Trailing punctuation in heading](https://github.com/DavidAnson/markdownlint/blob/master/doc/Rules.md#md026---trailing-punctuation-in-heading) | 标题末尾仅能出现中英文问号、反引号、中英文单双引号等符号。其余如**冒号**、逗号、句号、感叹号等符号均不能在标题末尾使用。 |
| 7 | [MD022 - Headings should be surrounded by blank lines](https://github.com/DavidAnson/markdownlint/blob/master/doc/Rules.md#md022---headings-should-be-surrounded-by-blank-lines) | 标题上下均须空一行。 |
| 8 | [MD024 - Multiple headings with the same content](https://github.com/DavidAnson/markdownlint/blob/master/doc/Rules.md#md024---multiple-headings-with-the-same-content) | 文档中不能连续出现内容重复的标题,如一级标题为 `# TiDB 架构`,紧接着的二级标题就不能是 `# TiDB 架构`。如果不是连续的标题,则标题内容可重复。 |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a typo? 😀

Suggested change
| 8 | [MD024 - Multiple headings with the same content](https://github.com/DavidAnson/markdownlint/blob/master/doc/Rules.md#md024---multiple-headings-with-the-same-content) | 文档中不能连续出现内容重复的标题,如一级标题为 `# TiDB 架构`,紧接着的二级标题就不能是 `# TiDB 架构`。如果不是连续的标题,则标题内容可重复。 |
| 8 | [MD024 - Multiple headings with the same content](https://github.com/DavidAnson/markdownlint/blob/master/doc/Rules.md#md024---multiple-headings-with-the-same-content) | 文档中不能连续出现内容重复的标题,如一级标题为 `# TiDB 架构`,紧接着的二级标题就不能是 `## TiDB 架构`。如果不是连续的标题,则标题内容可重复。 |

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ran-huang Yes. Good catch! Would you please help fix this typo in all versions? (including release-2.0 & release-1.0)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I'll fix this later~

@lilin90 lilin90 added the requires-followup This PR requires a follow-up task after being merged. label Mar 5, 2020
@lilin90 lilin90 removed the requires-followup This PR requires a follow-up task after being merged. label Jul 17, 2020
@lilin90 lilin90 added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Jul 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/large Changes of a large size. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants