-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
how-to: fix typos in placement rules doc #2643
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomShawn
added
translation/done
This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
type/bugfix
This PR fixes a bug.
needs-cherry-pick-4.0
labels
Apr 7, 2020
5 tasks
lilin90
approved these changes
Apr 7, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
cherry pick to release-4.0 in PR #2646 |
lilin90
pushed a commit
that referenced
this pull request
Apr 7, 2020
yikeke
added a commit
that referenced
this pull request
Apr 8, 2020
) * *: update some guiding resources #2628 * readme: update release-3.0 description * sql: add more info about load data (#2568) * reference/performance: specify index name of primary key for USE_INDEX_MERGE (#2350) Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com> * how-to: fix typos in placement rules doc (#2643) * reference: update TiFlash tune doc (#2642) * reference: update tiflash tune doc * Update tune-performance.md * Update reference/tiflash/tune-performance.md Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com> Co-authored-by: Soup <maxiaoyu@pingcap.com> Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com> * TiUP: document how to use TiUP to deploy TiDB v4.0 (#2635) * Use of TiUP to deploy TiDB of v4.0 version * Use of TiUP to deploy TiDB of v4.0 version * Use of TiUP to deploy TiDB of v4.0 version * Use of TiUP to deploy TiDB of v4.0 version * refine content and format * refine format * Use of TiUP to deploy TiDB of v4.0 version * Use of TiUP to deploy TiDB of v4.0 version * Modify the file name to lowercase Modify the file name to lowercase * fix ci * refine the image names in media for SEO reasons * Use of TiUP to deploy TiDB of v4.0 version * Update how-to/deploy/orchestrated/tiup.md Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com> * Update how-to/deploy/orchestrated/tiup.md Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com> * Use of TiUP to deploy TiDB of v4.0 version * refine content and format * Update how-to/deploy/orchestrated/tiup.md Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com> * refine title * Update how-to/deploy/orchestrated/tiup.md Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com> * add hyperlinks * fix ci * refine title * remove an unfinished note Co-authored-by: yikeke <yikeke@pingcap.com> Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com> * tiflash: update tiflash deploy document (ansible -> tiup) (#2641) * update tiflash doc for 4.0 * Update reference/tiflash/deploy.md Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com> * Update reference/tiflash/deploy.md Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com> * Update reference/tiflash/deploy.md Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com> * Update reference/tiflash/deploy.md Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com> * Update reference/tiflash/deploy.md Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com> * Update reference/tiflash/deploy.md Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com> * Update reference/tiflash/deploy.md Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com> * Update reference/tiflash/scale.md Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com> * Update reference/tiflash/deploy.md Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com> * minor edits to refine format Co-authored-by: Soup <maxiaoyu@pingcap.com> Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com> Co-authored-by: yikeke <yikeke@pingcap.com> * tiflash: update tiflash deploy document (ansible -> tiup) (#2641) * update tiflash doc for 4.0 * Update reference/tiflash/deploy.md Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com> * Update reference/tiflash/deploy.md Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com> * Update reference/tiflash/deploy.md Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com> * Update reference/tiflash/deploy.md Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com> * Update reference/tiflash/deploy.md Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com> * Update reference/tiflash/deploy.md Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com> * Update reference/tiflash/deploy.md Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com> * Update reference/tiflash/scale.md Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com> * Update reference/tiflash/deploy.md Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com> * minor edits to refine format Co-authored-by: Soup <maxiaoyu@pingcap.com> Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com> Co-authored-by: yikeke <yikeke@pingcap.com> * tiup: fix tiup deployment doc (#2651) * Modify the details * Modify the details * reference/configuration: add description about TiDB txn-total-size-limit (#2456) * reference/configuration: add tidb_row_format_version (#2605) * Revert "Merge branch 'master' into pr/2650" This reverts commit 2430b5c, reversing changes made to 2ea8409. Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com> Co-authored-by: Lilian Lee <lilin@pingcap.com> Co-authored-by: Lingyu Song <songlingyu@pingcap.com> Co-authored-by: Kenan Yao <cauchy1992@gmail.com> Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com> Co-authored-by: xufei <xufei@pingcap.com> Co-authored-by: Soup <maxiaoyu@pingcap.com> Co-authored-by: lzs <43946384+superlzs0476@users.noreply.github.com> Co-authored-by: yikeke <yikeke@pingcap.com> Co-authored-by: Liangliang Gu <marsishandsome@gmail.com> Co-authored-by: tiancaiamao <tiancaiamao@gmail.com> Co-authored-by: lysu <sulifx@gmail.com>
rleungx
pushed a commit
to rleungx/docs-cn
that referenced
this pull request
May 22, 2020
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
translation/done
This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
type/bugfix
This PR fixes a bug.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is changed, added or deleted? (Required)
Fix typos in the Placement Rules document.
Which TiDB version(s) do your changes apply to? (Required)
If you select two or more versions from above, to trigger the bot to cherry-pick this PR to your desired release version branch(es), you must add corresponding labels such as needs-cherry-pick-4.0, needs-cherry-pick-3.1, needs-cherry-pick-3.0, and needs-cherry-pick-2.1.
What is the related PR or file link(s)?