Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update use-tiflash.md (#2696) #2698

Merged
merged 2 commits into from
Apr 10, 2020
Merged

Update use-tiflash.md (#2696) #2698

merged 2 commits into from
Apr 10, 2020

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Apr 10, 2020

cherry-pick #2696 to release-4.0

Normalize two inconsistent samples.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)

@sre-bot sre-bot mentioned this pull request Apr 10, 2020
Merged
3 tasks
@sre-bot sre-bot added size/small Changes of a small size. type/cherry-pick-for-release-4.0 This PR is cherry-picked to release-4.0 from a source PR. labels Apr 10, 2020
@sre-bot sre-bot requested a review from lilin90 April 10, 2020 04:21
lilin90
lilin90 approved these changes Apr 10, 2020
View reviewed changes
Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lilin90 lilin90 added the status/can-merge Indicates a PR has been approved by a committer. label Apr 10, 2020
@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 10, 2020

/run-all-tests

@sre-bot sre-bot merged commit a2e6f0d into pingcap:release-4.0 Apr 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lilin90 lilin90 lilin90 approved these changes

Assignees
No one assigned
Labels
size/small Changes of a small size. status/can-merge Indicates a PR has been approved by a committer. type/cherry-pick-for-release-4.0 This PR is cherry-picked to release-4.0 from a source PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sre-bot @lilin90 @ilovesoup2000