-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix hardware-and-software-requirements #3228
Merged
sre-bot
merged 6 commits into
pingcap:docs-special-week
from
superlzs0476:lizhongshu-patch-1
May 26, 2020
Merged
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
ddbd573
fix hardware-and-software-requirements
5f0dc96
Update hardware-and-software-requirements.md
superlzs0476 99cacab
Merge branch 'docs-special-week' into lizhongshu-patch-1
superlzs0476 c3c99e6
Merge branch 'docs-special-week' into lizhongshu-patch-1
superlzs0476 140b4b6
Update hardware-and-software-requirements.md
lilin90 7a801e9
Merge branch 'docs-special-week' into lizhongshu-patch-1
sre-bot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
我觉得这里的链接应该给
production-deployment-using-tiup.md#第-2-步在中控机上安装-tiup-组件
, @superlzs0476 确认下?FYI @ran-huang 可能需要改 pingcap/docs#2658 的链接
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
已向 @superlzs0476 确认,这儿的链接是为了让用户学习一下 TiUP,不仅仅为了安装。所以应该改为 /tiup/tiup-documentation-guide.md,帮忙更新下 pingcap/docs#2658 的链接吧 @ran-huang 以及提个 PR fix docs-cn 这个链接吧(后续部署相关的中文问题都可以在这个 PR 里修复)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in #3457