Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zh: update backup & restore table filter usage and bump tidb cluster version to v4.0.6 #699

Merged
merged 5 commits into from
Sep 17, 2020

Conversation

lichunzhu
Copy link
Contributor

@lichunzhu lichunzhu commented Sep 14, 2020

What is changed, added or deleted? (Required)

#671
TiDB-operator has updated backup and restore table filters in pingcap/tidb-operator#3134. This PR will also update the usage of table filter and bump tidb version to v4.0.6.

Which TiDB Operator version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v1.1 (TiDB Operator 1.1 versions)
  • v1.0 (TiDB Operator 1.0 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Have version specific changes
  • Might cause conflicts

@lichunzhu
Copy link
Contributor Author

This PR should be merged after version v4.0.6 is released.

@lichunzhu
Copy link
Contributor Author

/cc ran-huang,DanielZhangQD

@lichunzhu
Copy link
Contributor Author

/label needs-cherry-pick-1.1

@ti-srebot ti-srebot added the needs-cherry-pick-release-1.1 Should cherry pick this PR to release-1.1 branch. label Sep 14, 2020

```
options:
- --threads=16
- --rows=10000
```

* `.spec.storageClassName`:备份时指定所需的 persistent volume (PV) 类型。如果不指定该项,则默认使用 TiDB Operator 启动参数中 `default-backup-storage-class-name` 指定的值,该值默认为 `standard`。
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

default-backup-storage-class-name 这个没有了

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

删掉了

Copy link
Contributor

@DanielZhangQD DanielZhangQD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 14, 2020
@@ -168,12 +168,19 @@ GCS 支持以下几种 bucket ACL 策略:
* `.spec.from.tidbSecretName`:待备份 TiDB 集群所需凭证的 secret。
* `.spec.gcs.bucket`:存储数据的 bucket 名字。
* `.spec.gcs.prefix`:这个字段可以省略,如果设置了这个字段,则会使用这个字段来拼接在远端存储的存储路径 `s3://${.spec.gcs.bucket}/${.spec.gcs.prefix}/backupName`。
* `.spec.dumpling`:Dumpling 相关的配置,主要有两个字段:一个是 `options` 字段,里面可以指定 Dumpling 的运行参数,详情见 [Dumpling 使用文档](https://docs.pingcap.com/zh/tidb/dev/dumpling-overview#dumpling-主要参数表);一个是 `tableFilter` 字段,可以指定让 Dumpling 备份符合 [table-filter 规则](https://docs.pingcap.com/zh/tidb/stable/table-filter/) 的表。默认情况下 dumpling 这个字段可以不用配置。当不指定 dumpling 的配置时,`options` 和 `tableFilter` 字段的默认值如下:
* `.spec.dumpling`:Dumpling 相关的配置,可以在 `options` 字段指定 Dumpling 的运行参数,详情见 [Dumpling 使用文档](https://docs.pingcap.com/zh/tidb/dev/dumpling-overview#dumpling-主要参数表);默认情况下该字段可以不用配置。当不指定 dumpling 的配置时,`options` 字段的默认值如下:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* `.spec.dumpling`:Dumpling 相关的配置,可以在 `options` 字段指定 Dumpling 的运行参数,详情见 [Dumpling 使用文档](https://docs.pingcap.com/zh/tidb/dev/dumpling-overview#dumpling-主要参数表);默认情况下该字段可以不用配置。当不指定 dumpling 的配置时,`options` 字段的默认值如下:
* `.spec.dumpling`:Dumpling 相关的配置,可以在 `options` 字段指定 Dumpling 的运行参数,详情见 [Dumpling 使用文档](https://docs.pingcap.com/zh/tidb/dev/dumpling-overview#dumpling-主要参数表);默认情况下该字段可以不用配置。当不指定 Dumpling 的配置时,`options` 字段的默认值如下:

@@ -280,12 +280,19 @@ kubectl get bk -n test1 -owide
* `.spec.s3.region`:使用 Amazon S3 存储备份,需要配置 Amazon S3 所在的 region。
* `.spec.s3.bucket`:兼容 S3 存储的 bucket 名字。
* `.spec.s3.prefix`:这个字段可以省略,如果设置了这个字段,则会使用这个字段来拼接在远端存储的存储路径 `s3://${.spec.s3.bucket}/${.spec.s3.prefix}/backupName`。
* `.spec.dumpling`:Dumpling 相关的配置,主要有两个字段:一个是 `options` 字段,里面可以指定 Dumpling 的运行参数,详情见 [Dumpling 使用文档](https://docs.pingcap.com/zh/tidb/dev/dumpling-overview#dumpling-主要参数表);一个是 `tableFilter` 字段,可以指定让 Dumpling 备份符合 [table-filter 规则](https://docs.pingcap.com/zh/tidb/stable/table-filter/) 的表。默认情况下 dumpling 这个字段可以不用配置。当不指定 dumpling 的配置时,`options` 和 `tableFilter` 字段的默认值如下:
* `.spec.dumpling`:Dumpling 相关的配置,可以在 `options` 字段指定 Dumpling 的运行参数,详情见 [Dumpling 使用文档](https://docs.pingcap.com/zh/tidb/dev/dumpling-overview#dumpling-主要参数表);默认情况下该字段可以不用配置。当不指定 dumpling 的配置时,`options` 字段的默认值如下:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* `.spec.dumpling`:Dumpling 相关的配置,可以在 `options` 字段指定 Dumpling 的运行参数,详情见 [Dumpling 使用文档](https://docs.pingcap.com/zh/tidb/dev/dumpling-overview#dumpling-主要参数表);默认情况下该字段可以不用配置。当不指定 dumpling 的配置时,`options` 字段的默认值如下:
* `.spec.dumpling`:Dumpling 相关的配置,可以在 `options` 字段指定 Dumpling 的运行参数,详情见 [Dumpling 使用文档](https://docs.pingcap.com/zh/tidb/dev/dumpling-overview#dumpling-主要参数表);默认情况下该字段可以不用配置。当不指定 Dumpling 的配置时,`options` 字段的默认值如下:


> **注意:**
>
> tableFilter 如果要写排除规则导出除 db.table 的所有表 "!db.table" 必须先添加 `*.*` 规则来导出所有表,如下面例子所示:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
> tableFilter 如果要写排除规则导出除 db.table 的所有表 "!db.table" 必须先添加 `*.*` 规则来导出所有表,如下面例子所示:
> `tableFilter` 如果要写排除规则导出除 `db.table` 的所有表,`"!db.table"` 前必须先添加 `*.*` 规则来导出所有表,如下面例子所示:


> **注意:**
>
> tableFilter 如果要写排除规则导出除 db.table 的所有表 "!db.table" 必须先添加 `*.*` 规则来导出所有表,如下面例子所示:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
> tableFilter 如果要写排除规则导出除 db.table 的所有表 "!db.table" 必须先添加 `*.*` 规则来导出所有表,如下面例子所示:
> `tableFilter` 如果要写排除规则导出除 `db.table` 的所有表,`"!db.table"` 前必须先添加 `*.*` 规则来导出所有表,如下面例子所示:


> **注意:**
>
> tableFilter 如果要写排除规则导出除 db.table 的所有表 "!db.table" 必须先添加 `*.*` 规则来导出所有表,如下面例子所示:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
> tableFilter 如果要写排除规则导出除 db.table 的所有表 "!db.table" 必须先添加 `*.*` 规则来导出所有表,如下面例子所示:
> `tableFilter` 如果要写排除规则导出除 `db.table` 的所有表,`"!db.table"` 前必须先添加 `*.*` 规则来导出所有表,如下面例子所示:

@ran-huang ran-huang added the translation/doing This PR’s assignee is translating this PR. label Sep 16, 2020
@ran-huang ran-huang self-assigned this Sep 16, 2020
@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Sep 16, 2020
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Sep 16, 2020
@ran-huang
Copy link
Contributor

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 16, 2020
@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot ti-srebot merged commit 420af7f into pingcap:master Sep 17, 2020
ti-srebot pushed a commit to ti-srebot/docs-tidb-operator that referenced this pull request Sep 17, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-1.1 in PR #705

ran-huang pushed a commit that referenced this pull request Sep 17, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: Chunzhu Li <lichunzhu@stu.xjtu.edu.cn>
@ran-huang ran-huang added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Sep 17, 2020
@july2993 july2993 mentioned this pull request Oct 16, 2020
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-cherry-pick-release-1.1 Should cherry pick this PR to release-1.1 branch. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants