Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-Authored-By: kennytm <kennytm@gmail.com>
  • Loading branch information
lonng and kennytm authored May 8, 2019
1 parent a1a0d1d commit 9b465f2
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion tools/lightning/deployment.md
Original file line number Diff line number Diff line change
Expand Up @@ -238,7 +238,7 @@ Download the TiDB-Lightning package (choose the same version as that of the TiDB
# Maximum number of open engines.
max-open-engines = 8
# Maximum upload speed (bytes per second) from Importer to TiKV.
upload-speed-limit = "512MB"
#upload-speed-limit = "512MB"
# minimum ratio of target store available space: store_available_space / store_capacity.
# Importer pauses uploading SST if the availability ratio of the target store is less than this
# value, to give PD enough time to balance regions.
Expand Down
4 changes: 2 additions & 2 deletions tools/lightning/errors.md
Original file line number Diff line number Diff line change
Expand Up @@ -77,9 +77,9 @@ See the [Checkpoints control](../../tools/lightning/checkpoints.md#checkpoints-c
Max Memory Usage ≈ `max-open-engine` × `write-buffer-size` × `max-write-buffer-number`

This comment has been minimized.

Copy link
@lonng

lonng May 8, 2019

Author Contributor

This line contains max-open-engine, also in L76, both need to change.

This comment has been minimized.

Copy link
@kennytm

kennytm May 8, 2019

Author Contributor

The remaining fixes are already included in 4e03ac0.

2. Decrease the value of `table-concurrency` + `index-concurrency` so it is less than `max-open-engine`.
2. Decrease the value of `table-concurrency` + `index-concurrency` so it is less than `max-open-engines`.
3. Restart `tikv-importer` to forcefully remove all engine files. This also removes all partially imported tables, thus it is required to clear the outdated checkpoints.
3. Restart `tikv-importer` to forcefully remove all engine files (default to `./data.import/`). This also removes all partially imported tables, thus it is required to clear the outdated checkpoints.
```sh
tidb-lightning-ctl --config conf/tidb-lightning.toml --checkpoint-error-destroy=all
Expand Down

0 comments on commit 9b465f2

Please sign in to comment.