Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools/lightning: update wording for multiple lighting docs #1121

Merged
merged 5 commits into from
May 30, 2019

Conversation

dcalvin
Copy link
Contributor

@dcalvin dcalvin commented May 9, 2019

Follow-up editing on #1087.
Involve multiple edits on formatting and wording for consistency and accuracy.

@dcalvin dcalvin requested review from kennytm and CaitinChen May 9, 2019 11:40
Copy link
Contributor

@kennytm kennytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@CaitinChen CaitinChen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We usually do not leave a space before or after "/". Please help update it. Thanks.

tools/lightning/deployment.md Outdated Show resolved Hide resolved
tools/lightning/deployment.md Outdated Show resolved Hide resolved
dcalvin and others added 2 commits May 10, 2019 15:04
Co-Authored-By: Caitin <34535727+CaitinChen@users.noreply.github.com>
Co-Authored-By: Caitin <34535727+CaitinChen@users.noreply.github.com>
@dcalvin
Copy link
Contributor Author

dcalvin commented May 10, 2019

PTAL again @CaitinChen Thanks.

@morgo
Copy link
Contributor

morgo commented May 10, 2019

@dcalvin There is a merge conflict, please resolve

@CaitinChen
Copy link
Contributor

Please help remove the spaces before and after "/". Thanks.

Copy link
Contributor

@CaitinChen CaitinChen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CaitinChen CaitinChen merged commit 0d6cba5 into pingcap:master May 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants