v2.1, v3.0, dev: fix inconsistent word usage #1287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morgo
approved these changes
Jun 27, 2019
There was a problem hiding this comment.
LGTM
For context: CREATE TABLE AS is valid MySQL syntax. We have a PR to add it, but it's currently stalled: pingcap/tidb#7787 It is on the mysql-compatibility page.
Okay, thanks for letting me know. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found that we used two different names for the SQL statement - CREATE TABLE LIKE and CREATE TABLE AS in our documents. According to the usage examples in the document, I think we should use the former one.
@morgo PTAL