Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: add variable tidb_enable_inl_join_inner_multi_pattern #12944

Merged
merged 3 commits into from
Mar 20, 2023
Merged

planner: add variable tidb_enable_inl_join_inner_multi_pattern #12944

merged 3 commits into from
Mar 20, 2023

Conversation

Oreoxmt
Copy link
Collaborator

@Oreoxmt Oreoxmt commented Mar 17, 2023

What is changed, added or deleted? (Required)

Add a new variable tidb_enable_inl_join_inner_multi_pattern to control whether the inner table of Index Join supports Selection or Projection operators.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v7.0 (TiDB 7.0 versions)
  • v6.6 (TiDB 6.6 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.4 (TiDB 6.4 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@Oreoxmt
planner: add variable tidb_enable_inl_join_inner_multi_pattern
e701fe2 
Signed-off-by: Aolin <aolin.zhang@pingcap.com>
@Oreoxmt Oreoxmt added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. v7.0 labels Mar 17, 2023
@Oreoxmt Oreoxmt self-assigned this Mar 17, 2023
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 17, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • ran-huang

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 17, 2023
@Oreoxmt Oreoxmt added the area/planner Indicates that the Issue or PR belongs to the area of SQL planner or optimizer. label Mar 17, 2023
chrysan
chrysan reviewed Mar 17, 2023
View reviewed changes
system-variables.md Outdated Show resolved Hide resolved
Oreoxmt
Oreoxmt commented Mar 17, 2023
View reviewed changes
system-variables.md Outdated Show resolved Hide resolved
@Oreoxmt
Copy link
Collaborator Author

Oreoxmt commented Mar 17, 2023

/status LGT1

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 17, 2023
Oreoxmt
Oreoxmt commented Mar 17, 2023
View reviewed changes
system-variables.md Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 17, 2023
@Oreoxmt
Copy link
Collaborator Author

Oreoxmt commented Mar 20, 2023

/verify
/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 041f8af

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 20, 2023
@ti-chi-bot ti-chi-bot merged commit a41d28e into pingcap:master Mar 20, 2023
@yahonda
Copy link
Member

yahonda commented Apr 13, 2023

Would you consider to backport this change to release-6.1 because TiDB 6.1.6 has been released that includes pingcap/tidb#41326

@Oreoxmt Oreoxmt added the needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. label Apr 13, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request Apr 13, 2023
Merged
15 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.1: #13239.

ti-chi-bot added a commit that referenced this pull request Apr 14, 2023
@ti-chi-bot
planner: add variable tidb_enable_inl_join_inner_multi_pattern (#12944)…
f017d78 
… (#13239)
@Oreoxmt Oreoxmt deleted the translate/docs-cn-13451 branch April 14, 2023 02:36
@Oreoxmt
Copy link
Collaborator Author

Oreoxmt commented Apr 14, 2023

Would you consider to backport this change to release-6.1 because TiDB 6.1.6 has been released that includes pingcap/tidb#41326

@yahonda tidb_enable_inl_join_inner_multi_pattern has been added to release-6.1 (#13239)

@ran-huang ran-huang added the needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. label Apr 19, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request Apr 19, 2023
Merged
15 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #13296.

ran-huang added a commit that referenced this pull request Apr 21, 2023
@ti-chi-bot @Oreoxmt @ran-huang
planner: add variable tidb_enable_inl_join_inner_multi_pattern (#12944)…
0f2b9fb 
… (#13296)

* planner: add variable tidb_enable_inl_join_inner_multi_pattern

Signed-off-by: Aolin <aolin.zhang@pingcap.com>

* Apply suggestions from code review

* Apply suggestions from code review

* Update system-variables.md

---------

Signed-off-by: Aolin <aolin.zhang@pingcap.com>
Co-authored-by: Aolin <aolin.zhang@pingcap.com>
Co-authored-by: Ran <huangran.alex@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrysan chrysan chrysan approved these changes

@ran-huang ran-huang ran-huang approved these changes

Assignees

@Oreoxmt Oreoxmt

Labels
area/planner Indicates that the Issue or PR belongs to the area of SQL planner or optimizer. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. v7.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Oreoxmt @ti-chi-bot @yahonda @chrysan @ran-huang