Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: add marklint check for changed files in PR #1406

Merged
merged 4 commits into from
Aug 5, 2019

Conversation

aylei
Copy link
Contributor

@aylei aylei commented Aug 1, 2019

Signed-off-by: Aylei rayingecho@gmail.com

What is changed, added or deleted?

Add marklint check for changed files in PR.

Note: authors may find unexpectedly changed files in the CI check if their branches are outdated, merge master branch will help in such senario.

Related PR: pingcap/docs-cn#1494

Which version does your change affect?

*

Checklist

  • Add a new file to TOC.md
  • No Tab spaces anywhere
  • Leave a blank line both before and after a code block
  • Keep the first level heading consistent with title in metadata
  • Use four spaces for each level of indentation except that in TOC.md

@YiniXu9506 @yikeke @lilin90 PTAL

@YiniXu9506 Additional notes for CircleCI: checking Pull Requests requires special configuration for repository, I've updated the configuration in the CircleCI console, PTAL too.

Signed-off-by: Aylei <rayingecho@gmail.com>
Signed-off-by: Aylei <rayingecho@gmail.com>
Copy link
Contributor

@YiniXu9506 YiniXu9506 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yikeke yikeke added the DNM label Aug 1, 2019
@yikeke
Copy link
Contributor

yikeke commented Aug 1, 2019

Thanks! I will open another pull request to fix all existing lint issues. Please merge this PR after that. FYI. @lilin90

@lilin90
Copy link
Member

lilin90 commented Aug 2, 2019

@yikeke Got it. Thanks!

@lilin90 lilin90 changed the title *: Add marklint check for changed files in PR *: add marklint check for changed files in PR Aug 2, 2019
@lilin90 lilin90 added the website label Aug 2, 2019
@yikeke
Copy link
Contributor

yikeke commented Aug 3, 2019

Thanks! I will open another pull request to fix all existing lint issues. Please merge this PR after that. FYI. @lilin90

See #1410.

Copy link
Contributor

@yikeke yikeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yikeke yikeke merged commit 8ccd684 into pingcap:master Aug 5, 2019
@yikeke yikeke added improvement and removed DNM labels Aug 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants