-
Notifications
You must be signed in to change notification settings - Fork 673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: add marklint check for changed files in PR #1406
Conversation
Signed-off-by: Aylei <rayingecho@gmail.com>
Signed-off-by: Aylei <rayingecho@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks! I will open another pull request to fix all existing lint issues. Please merge this PR after that. FYI. @lilin90 |
@yikeke Got it. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Aylei rayingecho@gmail.com
What is changed, added or deleted?
Add marklint check for changed files in PR.
Note: authors may find unexpectedly changed files in the CI check if their branches are outdated, merge master branch will help in such senario.
Related PR: pingcap/docs-cn#1494
Which version does your change affect?
*
Checklist
TOC.md
title
in metadataTOC.md
@YiniXu9506 @yikeke @lilin90 PTAL
@YiniXu9506 Additional notes for CircleCI: checking Pull Requests requires special configuration for repository, I've updated the configuration in the CircleCI console, PTAL too.