Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reference/performance: fix EXPLAIN ANALYZE output format #1922

Merged
merged 2 commits into from
Mar 4, 2020
Merged

reference/performance: fix EXPLAIN ANALYZE output format #1922

merged 2 commits into from
Mar 4, 2020

Conversation

LittleFall
Copy link
Contributor

What is changed, added or deleted?

In explain analyze statements, count should be compared to rows, instead of rows/loops.

This PR fixed it.

@TomShawn TomShawn added the translation/doing This PR's assignee is translating this PR. label Mar 2, 2020
@LittleFall LittleFall changed the title Fix EXPLAIN ANALYZE output format. reference/performance: Fix EXPLAIN ANALYZE output format. Mar 2, 2020
@LittleFall LittleFall added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. needs-cherry-pick-2.1 size/small Changes of a small size. labels Mar 2, 2020
@CaitinChen CaitinChen requested review from toutdesuite and removed request for CaitinChen March 2, 2020 12:56
@yikeke yikeke requested a review from zz-jason March 4, 2020 03:56
@yikeke yikeke removed the translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. label Mar 4, 2020
zz-jason
zz-jason approved these changes Mar 4, 2020
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LittleFall LittleFall merged commit 076de80 into master Mar 4, 2020
sre-bot pushed a commit to sre-bot/docs that referenced this pull request Mar 4, 2020
@LittleFall @sre-bot
Fix EXPLAIN ANALYZE output format. (pingcap#1922)
3067bdc
@sre-bot sre-bot mentioned this pull request Mar 4, 2020
Merged
@sre-bot
Copy link
Contributor

sre-bot commented Mar 4, 2020

cherry pick to release-2.1 in PR #1940

sre-bot pushed a commit to sre-bot/docs that referenced this pull request Mar 4, 2020
@LittleFall @sre-bot
Fix EXPLAIN ANALYZE output format. (pingcap#1922)
20c0292
@sre-bot sre-bot mentioned this pull request Mar 4, 2020
Merged
@sre-bot
Copy link
Contributor

sre-bot commented Mar 4, 2020

cherry pick to release-3.0 in PR #1941

sre-bot pushed a commit to sre-bot/docs that referenced this pull request Mar 4, 2020
@LittleFall @sre-bot
Fix EXPLAIN ANALYZE output format. (pingcap#1922)
f2e4b5e
@sre-bot sre-bot mentioned this pull request Mar 4, 2020
Merged
@sre-bot
Copy link
Contributor

sre-bot commented Mar 4, 2020

cherry pick to release-3.1 in PR #1942

LittleFall added a commit that referenced this pull request Mar 6, 2020
@sre-bot @LittleFall
Fix EXPLAIN ANALYZE output format. (#1922) (#1942)
02ccf78 
Co-authored-by: Zhi Qi <30543181+LittleFall@users.noreply.github.com>
@lilin90 lilin90 deleted the LittleFall-patch-2 branch March 6, 2020 04:22
@lilin90 lilin90 changed the title reference/performance: Fix EXPLAIN ANALYZE output format. reference/performance: fix EXPLAIN ANALYZE output format Mar 6, 2020
@toutdesuite toutdesuite added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR's assignee is translating this PR. labels Mar 6, 2020
yikeke added a commit that referenced this pull request Mar 9, 2020
@sre-bot @LittleFall @yikeke
Fix EXPLAIN ANALYZE output format. (#1922) (#1941)
5ab9c5a 
Co-authored-by: Zhi Qi <30543181+LittleFall@users.noreply.github.com>
Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>
sticnarf pushed a commit to sticnarf/docs that referenced this pull request Mar 20, 2020
@LittleFall @sticnarf
Fix EXPLAIN ANALYZE output format. (pingcap#1922)
e2442ac
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zz-jason zz-jason zz-jason approved these changes

@toutdesuite toutdesuite toutdesuite approved these changes

Assignees

@toutdesuite toutdesuite

Labels
size/small Changes of a small size. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@LittleFall @sre-bot @zz-jason @toutdesuite @yikeke @TomShawn