Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reference/sql: list valid length value ranges in VARCHAR for different charsets (#2109) #2131

Merged
merged 2 commits into from
Apr 1, 2020

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Mar 31, 2020

cherry-pick #2109 to release-3.1


What is changed, added or deleted? (Required)

The current description of string type is confusing.

VARCHAR 的最大实际长度由最长的行的大小和使用的字符集确定。

A few sentences are clarified.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version, including v4.0 changes for now)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

If you select two or more versions from above, to trigger the bot to cherry-pick this PR to your desired release version branch(es), you must add corresponding labels such as needs-cherry-pick-3.1, needs-cherry-pick-3.0, and needs-cherry-pick-2.1.

What is the related PR or file link(s)?

…t charsets (pingcap#2109)

* reference/sql: list valid length value ranges in VARCHAR for different charsets

* Update string.md

* Update reference/sql/data-types/string.md

Co-Authored-By: djshow832 <873581766@qq.com>

* Update reference/sql/data-types/string.md

Co-Authored-By: djshow832 <873581766@qq.com>

* address comments

* add another link

Co-authored-by: djshow832 <873581766@qq.com>
Co-authored-by: pingcap-github-bot <sre-bot@pingcap.com>
@sre-bot sre-bot added the type/cherry-pick-for-release-3.1 This PR is cherry-picked to release-3.1 from a source PR. label Mar 31, 2020
Copy link
Contributor

@djshow832 djshow832 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yikeke
Copy link
Contributor

yikeke commented Apr 1, 2020

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 1, 2020
@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 1, 2020

Your auto merge job has been accepted, waiting for 2129, 2130

@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 1, 2020

/run-all-tests

@sre-bot sre-bot merged commit 36c6bd8 into pingcap:release-3.1 Apr 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/can-merge Indicates a PR has been approved by a committer. type/cherry-pick-for-release-3.1 This PR is cherry-picked to release-3.1 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants