Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev-guide: add draft metadata #2159

Merged
merged 2 commits into from
Apr 3, 2020
Merged

Conversation

lilin90
Copy link
Member

@lilin90 lilin90 commented Apr 3, 2020

What is changed, added or deleted? (Required)

Add draft: true metadata for three files in the dev-guide directory

  • To avoid them being built to the PingCAP website (these files are not actively maintained now)
  • To avoid the scripts link 404 error

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version, including v4.0 changes for now)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

If you select two or more versions from above, to trigger the bot to cherry-pick this PR to your desired release version branch(es), you must add corresponding labels such as needs-cherry-pick-3.1, needs-cherry-pick-3.0, and needs-cherry-pick-2.1.

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

@lilin90 lilin90 added the translation/doing This PR's assignee is translating this PR. label Apr 3, 2020
@lilin90 lilin90 requested a review from toutdesuite April 3, 2020 09:32
@lilin90 lilin90 self-assigned this Apr 3, 2020
@sre-bot sre-bot added the contribution This PR is from a community contributor. label Apr 3, 2020
Copy link
Contributor

@toutdesuite toutdesuite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lilin90 lilin90 added the status/can-merge Indicates a PR has been approved by a committer. label Apr 3, 2020
@lilin90 lilin90 merged commit e03e6a7 into pingcap:master Apr 3, 2020
sre-bot pushed a commit to sre-bot/docs that referenced this pull request Apr 3, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Apr 3, 2020

cherry pick to release-2.1 in PR #2160

sre-bot pushed a commit to sre-bot/docs that referenced this pull request Apr 3, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Apr 3, 2020

cherry pick to release-3.0 in PR #2161

sre-bot pushed a commit to sre-bot/docs that referenced this pull request Apr 3, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Apr 3, 2020

cherry pick to release-3.1 in PR #2162

@lilin90 lilin90 assigned toutdesuite and unassigned lilin90 Apr 3, 2020
@lilin90 lilin90 added translation/no-need No need to translate this PR. and removed translation/doing This PR's assignee is translating this PR. labels Apr 3, 2020
lilin90 added a commit that referenced this pull request Apr 3, 2020
Co-authored-by: Lilian Lee <lilin@pingcap.com>
lilin90 added a commit that referenced this pull request Apr 3, 2020
Co-authored-by: Lilian Lee <lilin@pingcap.com>
lilin90 added a commit that referenced this pull request Apr 3, 2020
Co-authored-by: Lilian Lee <lilin@pingcap.com>
@lilin90 lilin90 removed the contribution This PR is from a community contributor. label Apr 3, 2020
@lilin90 lilin90 deleted the update-dev-guide branch April 3, 2020 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/can-merge Indicates a PR has been approved by a committer. translation/no-need No need to translate this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants