Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tiflash: add the deploy.md doc #2164

Merged
merged 9 commits into from
Apr 7, 2020
Merged

Conversation

yikeke
Copy link
Contributor

@yikeke yikeke commented Apr 3, 2020

What is changed, added or deleted? (Required)

add the deploy.md doc

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

If you select two or more versions from above, to trigger the bot to cherry-pick this PR to your desired release version branch(es), you must add corresponding labels such as needs-cherry-pick-3.1, needs-cherry-pick-3.0, and needs-cherry-pick-2.1.

What is the related PR or file link(s)?

@yikeke yikeke requested review from ilovesoup and lilin90 April 3, 2020 14:00
@yikeke yikeke added needs-cherry-pick-3.1 translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. v4.0 This PR/issue applies to TiDB v4.0. labels Apr 3, 2020
Copy link
Contributor

@ilovesoup ilovesoup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made my change and LGTM

TOC.md Outdated Show resolved Hide resolved
reference/tiflash/deploy.md Outdated Show resolved Hide resolved
reference/tiflash/deploy.md Outdated Show resolved Hide resolved
reference/tiflash/deploy.md Outdated Show resolved Hide resolved
reference/tiflash/deploy.md Outdated Show resolved Hide resolved
reference/tiflash/deploy.md Outdated Show resolved Hide resolved
TOC.md Outdated Show resolved Hide resolved
TOC.md Outdated
@@ -302,6 +302,7 @@
- [TiKV Performance Tuning with Massive Regions](/reference/best-practices/massive-regions.md)
- [TiSpark](/reference/tispark.md)
+ TiFlash
- [Deploy TiFlash Cluster](/reference/tiflash/deploy.md)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- [Deploy TiFlash Cluster](/reference/tiflash/deploy.md)
- [Deploy a TiFlash Cluster](/reference/tiflash/deploy.md)

Co-Authored-By: Lilian Lee <lilin@pingcap.com>
Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yikeke yikeke merged commit 6548d8d into pingcap:master Apr 7, 2020
@yikeke yikeke deleted the add-tiflash-deploy-doc branch April 7, 2020 01:26
@lilin90 lilin90 added the priority/P1 The issue has P1 priority. label Apr 7, 2020
sre-bot pushed a commit to sre-bot/docs that referenced this pull request Apr 7, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
@sre-bot
Copy link
Contributor

sre-bot commented Apr 7, 2020

cherry pick to release-3.1 in PR #2175

sre-bot pushed a commit to sre-bot/docs that referenced this pull request Apr 7, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
@sre-bot
Copy link
Contributor

sre-bot commented Apr 7, 2020

cherry pick to release-4.0 in PR #2176

sre-bot added a commit that referenced this pull request Apr 7, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
yikeke added a commit that referenced this pull request Apr 7, 2020
* cherry pick #2164 to release-4.0

Signed-off-by: sre-bot <sre-bot@pingcap.com>

* resolve conflict

Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>
Co-authored-by: yikeke <yikeke@pingcap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/P1 The issue has P1 priority. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. v4.0 This PR/issue applies to TiDB v4.0.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants