Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tiflash: normalize two inconsistent samples #2236

Merged
merged 1 commit into from
Apr 10, 2020
Merged

tiflash: normalize two inconsistent samples #2236

merged 1 commit into from
Apr 10, 2020

Conversation

ilovesoup
Copy link
Contributor

@ilovesoup ilovesoup commented Apr 10, 2020 •
edited by lilin90
Loading

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)

Related PR: pingcap/docs-cn#2696

lilin90
lilin90 approved these changes Apr 10, 2020
View reviewed changes
Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lilin90 lilin90 added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. size/small Changes of a small size. labels Apr 10, 2020
@lilin90 lilin90 merged commit a35727f into master Apr 10, 2020
@lilin90 lilin90 deleted the ilovesoup-patch-1 branch April 10, 2020 04:20
sre-bot pushed a commit to sre-bot/docs that referenced this pull request Apr 10, 2020
@ilovesoup2000 @sre-bot
Update use-tiflash.md (pingcap#2236)
4a68445
@sre-bot sre-bot mentioned this pull request Apr 10, 2020
Merged
3 tasks
@sre-bot
Copy link
Contributor

sre-bot commented Apr 10, 2020

cherry pick to release-3.1 in PR #2237

sre-bot pushed a commit to sre-bot/docs that referenced this pull request Apr 10, 2020
@ilovesoup2000 @sre-bot
Update use-tiflash.md (pingcap#2236)
9e0a176
@sre-bot sre-bot mentioned this pull request Apr 10, 2020
Merged
3 tasks
@sre-bot
Copy link
Contributor

sre-bot commented Apr 10, 2020

cherry pick to release-4.0 in PR #2238

@ilovesoup ilovesoup mentioned this pull request Apr 10, 2020
Merged
3 tasks
@lilin90 lilin90 changed the title Update use-tiflash.md tiflash: normalize two inconsistent samples Apr 10, 2020
lilin90 pushed a commit that referenced this pull request Apr 10, 2020
@sre-bot @ilovesoup2000
Update use-tiflash.md (#2236) (#2237)
cb4b6bf 
Co-authored-by: Soup <ilovesoup@gmail.com>
lilin90 added a commit that referenced this pull request Apr 10, 2020
@sre-bot @ilovesoup2000 @lilin90
Update use-tiflash.md (#2236) (#2238)
1c2ef05 
Co-authored-by: Soup <ilovesoup@gmail.com>
Co-authored-by: Lilian Lee <lilin@pingcap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lilin90 lilin90 lilin90 approved these changes

Assignees
No one assigned
Labels
size/small Changes of a small size. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ilovesoup @sre-bot @lilin90 @ilovesoup2000