Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tiflash: fix architecture image #2247

Merged
merged 2 commits into from
Apr 12, 2020
Merged

tiflash: fix architecture image #2247

merged 2 commits into from
Apr 12, 2020

Conversation

ran-huang
Copy link
Contributor

What is changed, added or deleted? (Required)

Fix the tiflash architecture image.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

If you select two or more versions from above, to trigger the bot to cherry-pick this PR to your desired release version branch(es), you must add corresponding labels such as needs-cherry-pick-4.0, needs-cherry-pick-3.1, needs-cherry-pick-3.0, and needs-cherry-pick-2.1.

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

@ran-huang ran-huang added the translation/no-need No need to translate this PR. label Apr 11, 2020
@CaitinChen
Copy link
Contributor

If you change tiflash-architecture.jpg to tiflash-architecture.png, you need to update the .md file accordingly. Alternatively, you can update the image format to .jpg.

@ran-huang
Copy link
Contributor Author

If you change tiflash-architecture.jpg to tiflash-architecture.png, you need to update the .md file accordingly. Alternatively, you can update the image format to .jpg.

Thanks! file link updated.

Copy link
Contributor

@CaitinChen CaitinChen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@ilovesoup ilovesoup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ran-huang ran-huang merged commit 53a049f into pingcap:master Apr 12, 2020
sre-bot pushed a commit to sre-bot/docs that referenced this pull request Apr 12, 2020
* tiflash: fix architecture image

* update link
@sre-bot
Copy link
Contributor

sre-bot commented Apr 12, 2020

cherry pick to release-3.1 in PR #2248

@ran-huang ran-huang deleted the fix-tiflash-pic branch April 12, 2020 06:42
sre-bot pushed a commit to sre-bot/docs that referenced this pull request Apr 12, 2020
* tiflash: fix architecture image

* update link
@sre-bot
Copy link
Contributor

sre-bot commented Apr 12, 2020

cherry pick to release-4.0 in PR #2249

ran-huang added a commit that referenced this pull request Apr 12, 2020
* tiflash: fix architecture image

* update link

Co-authored-by: Ran <huangran@pingcap.com>
ran-huang added a commit that referenced this pull request Apr 12, 2020
* tiflash: fix architecture image

* update link

Co-authored-by: Ran <huangran@pingcap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
translation/no-need No need to translate this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants