Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reference/configuration: add tidb_row_format_version #2290

Merged
merged 3 commits into from
Apr 16, 2020

Conversation

TomShawn
Copy link
Contributor

@TomShawn TomShawn commented Apr 15, 2020

What is changed, added or deleted? (Required)

Add description for new variable tidb_row_format_version.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

If you select two or more versions from above, to trigger the bot to cherry-pick this PR to your desired release version branch(es), you must add corresponding labels such as needs-cherry-pick-4.0, needs-cherry-pick-3.1, needs-cherry-pick-3.0, and needs-cherry-pick-2.1.

What is the related PR or file link(s)?

@TomShawn TomShawn added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. size/small Changes of a small size. status/PTAL This PR is ready for reviewing. needs-cherry-pick-4.0 labels Apr 15, 2020
@TomShawn TomShawn requested review from lysu and ran-huang April 15, 2020 11:47
@TomShawn TomShawn changed the title Tidb row format version reference/configuration: add tidb_row_format_version Apr 15, 2020
Copy link
Contributor

@lysu lysu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lysu lysu added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 15, 2020
Copy link
Contributor

@ran-huang ran-huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ran-huang ran-huang removed status/LGT1 Indicates that a PR has LGTM 1. status/PTAL This PR is ready for reviewing. labels Apr 16, 2020
@ran-huang ran-huang added the status/can-merge Indicates a PR has been approved by a committer. label Apr 16, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Apr 16, 2020

/run-all-tests

@sre-bot sre-bot merged commit b1e6a42 into pingcap:master Apr 16, 2020
sre-bot pushed a commit to sre-bot/docs that referenced this pull request Apr 16, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Apr 16, 2020

cherry pick to release-4.0 in PR #2299

@TomShawn TomShawn deleted the tidb_row_format_version branch April 16, 2020 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/small Changes of a small size. status/can-merge Indicates a PR has been approved by a committer. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants