-
Notifications
You must be signed in to change notification settings - Fork 678
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Translate tidb computing #3057
Translate tidb computing #3057
Conversation
@SunRunAway @yikeke PTAL, thanks! |
@SunRunAway, @TomShawn, PTAL. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good translation! I'll review the rest part soon.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The second round of review
@baurine, please update your pull request. |
LGTM |
@TomShawn, @SunRunAway, PTAL. |
@baurine, please update your pull request. |
Err, seems I have no permission to push code, what should I continue to do for this PR? |
@TomShawn, @SunRunAway, PTAL. |
@TomShawn, @SunRunAway, PTAL. |
@baurine, please update your pull request. |
Co-authored-by: Feng Liyuan <darktemplar.f@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@SunRunAway,Thanks for your review. However, LGTM is restricted to Reviewers or higher roles.See the corresponding SIG page for more information. Related SIGs: docs(slack). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
cherry pick to release-4.0 in PR #3341 |
* cherry pick #3057 to release-4.0 Signed-off-by: ti-srebot <ti-srebot@pingcap.com> * Apply suggestions from code review Co-authored-by: Sparkle <1284531+baurine@users.noreply.github.com> Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
What is changed, added or deleted? (Required)
Translate the TiDB Computation chapter from Chinese to English.
This PR should be merged after #3094 for the TOC to be updated.
Which TiDB version(s) do your changes apply to? (Required)
What is the related PR or file link(s)?