Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql: Improve Default Differences #605

Closed
wants to merge 2 commits into from
Closed

sql: Improve Default Differences #605

wants to merge 2 commits into from

Conversation

morgo
Copy link
Contributor

@morgo morgo commented Sep 7, 2018

Improved clarity:

The current text says the default is utf8mb4 in TiDB, and in MySQL 8.0 becomes utf8. It becomes utf8mb4 in 8.0, and technically is default utf8 in TiDB - it just works the same as utf8mb4.

Added Additional Difference:

The default SQL mode in TiDB differs from MySQL.

@morgo morgo changed the title sql: Clarify default is utf8 sql: Improve Default Differences Sep 7, 2018
@morgo morgo added the type/enhancement The issue or PR belongs to an enhancement. label Sep 10, 2018
@morgo morgo requested a review from lilin90 September 10, 2018 02:11
@QueenyJin
Copy link
Contributor

@shenli PTAL.

@morgo
Copy link
Contributor Author

morgo commented Sep 10, 2018

I am going to close this pull requests in #604

The two PRs are starting to overlap as I document other differences.

@morgo morgo closed this Sep 10, 2018
@morgo morgo deleted the patch-8 branch September 10, 2018 21:14
@sre-bot sre-bot added the contribution This PR is from a community contributor. label Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution This PR is from a community contributor. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants