Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dumpling: add a note about compression #6619

Merged
merged 3 commits into from
Nov 2, 2021
Merged

dumpling: add a note about compression #6619

merged 3 commits into from
Nov 2, 2021

Conversation

dveeden
Copy link
Contributor

@dveeden dveeden commented Oct 14, 2021 •
edited by hfxsd
Loading

What is changed, added or deleted? (Required)

Add a note about the --compress option for dumpling. See pingcap/dumpling#4 (comment) for more details.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 14, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 14, 2021
kennytm
kennytm approved these changes Oct 14, 2021
View reviewed changes
dumpling-overview.md Outdated Show resolved Hide resolved
@ti-chi-bot
Copy link
Member

@kennytm: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@TomShawn TomShawn added area/migrate Indicates that the Issue or PR belongs to the area of TiDB migration tools. translation/doing This PR's assignee is translating this PR. type/enhancement The issue or PR belongs to an enhancement. and removed missing-translation-status This PR does not have translation status info. labels Oct 15, 2021
@dveeden dveeden requested a review from kennytm November 1, 2021 14:48
@kennytm
Copy link
Contributor

kennytm commented Nov 1, 2021

lgtm.

@ti-chi-bot
Copy link
Member

@hfxsd: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 2, 2021
@TomShawn
Copy link
Contributor

TomShawn commented Nov 2, 2021

/remove-status LGT1
/status LGT2

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 2, 2021
@TomShawn
Copy link
Contributor

TomShawn commented Nov 2, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: ce79524

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 2, 2021
@ti-chi-bot ti-chi-bot merged commit 613b505 into pingcap:master Nov 2, 2021
@hfxsd hfxsd mentioned this pull request Mar 23, 2022
Merged
15 tasks
@hfxsd hfxsd removed the translation/doing This PR's assignee is translating this PR. label Mar 23, 2022
@hfxsd hfxsd added the translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. label Mar 23, 2022
This was referenced Mar 24, 2022
Merged
Merged
Merged
Merged
Merged
Merged
@ti-chi-bot ti-chi-bot mentioned this pull request Mar 24, 2022
Merged
8 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #7924.

@ti-chi-bot ti-chi-bot mentioned this pull request Mar 24, 2022
Merged
8 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #7925.

@ti-chi-bot ti-chi-bot mentioned this pull request Mar 24, 2022
Merged
8 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #7926.

@ti-chi-bot ti-chi-bot mentioned this pull request Mar 24, 2022
Merged
8 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #7927.

ti-chi-bot added a commit that referenced this pull request Mar 24, 2022
@ti-chi-bot
dumpling: add a note about compression (#6619) (#7924)
75492be
ti-chi-bot added a commit that referenced this pull request Mar 24, 2022
@ti-chi-bot
dumpling: add a note about compression (#6619) (#7926)
b645dc2
ti-chi-bot added a commit that referenced this pull request Mar 24, 2022
@ti-chi-bot
dumpling: add a note about compression (#6619) (#7925)
beae05d
ti-chi-bot added a commit that referenced this pull request Mar 24, 2022
@ti-chi-bot
dumpling: add a note about compression (#6619) (#7927)
7002a32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hfxsd hfxsd hfxsd approved these changes

@TomShawn TomShawn TomShawn approved these changes

@kennytm kennytm Awaiting requested review from kennytm

Assignees

@hfxsd hfxsd

Labels
area/migrate Indicates that the Issue or PR belongs to the area of TiDB migration tools. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dveeden @ti-chi-bot @kennytm @TomShawn @hfxsd